From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Merging the pgtk branch Date: Sun, 01 Aug 2021 12:57:15 -0400 Message-ID: References: <835ywpo8ar.fsf@gnu.org> <20210802.013859.2264148309496126056.masm@luna.pink.masm11.me> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29863"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: eliz@gnu.org, emacs-devel@gnu.org To: Yuuki Harano Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Aug 01 18:58:11 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mAEmx-0007YG-2I for ged-emacs-devel@m.gmane-mx.org; Sun, 01 Aug 2021 18:58:11 +0200 Original-Received: from localhost ([::1]:33194 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mAEmw-0007ni-4T for ged-emacs-devel@m.gmane-mx.org; Sun, 01 Aug 2021 12:58:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49828) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mAEmC-00074g-Ec for emacs-devel@gnu.org; Sun, 01 Aug 2021 12:57:24 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:22235) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mAEm8-0002YW-2X; Sun, 01 Aug 2021 12:57:23 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id EA97180904; Sun, 1 Aug 2021 12:57:17 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id C9EC780695; Sun, 1 Aug 2021 12:57:16 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1627837036; bh=4ly5Ssd7IH/iP0j2sGKPYLfxnNCBMfk8zk6o52Vn8HQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=NQFMDh8Y6gwkrDjFSG82xI0un63GgemAlRfF5fnhXkOk7DD0BPlfQWbwJUx1YD5Gn V11S8CLitIGOJ5MO6v/9nWXpyJdHC3nYdA38dewz4KNG1Kg5RniaD3AuTY6d3ZXshH 5evBcDpdzPpHeeBj6maxS0sMvBVEpQVGeAumYLRp+G7XtyS9bahjEet/MeKBDvSQ95 CrvgktdP/9OQUT5pFrqF1JKT9BTGpYonly9I1fPcn5pd2XplZuD2WB/XBrHdjg3B70 Hke0gRFHpj20nX8jl4JY6DeW1oaSCapDeDPZYDNkX1zWSiWVCYmxWkYo13i75mLYlJ /PBpnQ9r/gRnQ== Original-Received: from alfajor (unknown [216.154.29.138]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 95BD01201C1; Sun, 1 Aug 2021 12:57:16 -0400 (EDT) In-Reply-To: <20210802.013859.2264148309496126056.masm@luna.pink.masm11.me> (Yuuki Harano's message of "Mon, 02 Aug 2021 01:38:59 +0900 (JST)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:271920 Archived-At: >>> @@ -165,9 +168,9 @@ gui--selection-value-internal >>> Call `gui-get-selection' with an appropriate DATA-TYPE argument >>> decided by `x-select-request-type'. The return value is already >>> decoded. If `gui-get-selection' signals an error, return nil." >>> - (let ((request-type (if (eq window-system 'x) >>> + (let ((request-type (if (memq window-system '(x pgtk)) >>> (or x-select-request-type >>> - '(UTF8_STRING COMPOUND_TEXT STRING)) >>> + '(UTF8_STRING COMPOUND_TEXT STRING text/plain\;charset=utf-8)) >>> 'STRING)) >> >> Is it useful to have "text/plain\;charset=utf-8" here when >> window-system is 'x', not 'pgtk'? > > I think no. But the combination is not harmful. What is the intended difference between `UTF8_STRING` and `text/plain\;charset=utf-8`? >>> + ;; Don't let Emacs suspend under PGTK. >>> + (add-hook 'suspend-hook 'pgtk-suspend-error) >> What's this about? If PGTK doesn't want to be suspended, why do this >> via a hook? > If you try to suspend PGTK emacs via emacs running on a terminal (-nw), > the try will be rejected. Indeed, `grep suspend-hook` shows that all GUIs have this. We should consolidate this. Stefan