From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Buffer-local process environments Date: Sat, 28 Aug 2021 10:05:24 -0400 Message-ID: References: <87eeets6jf.fsf@gmail.com> <8735v99f4i.fsf@gmail.com> <87y2d1xada.fsf@gmx.de> <877dkkcjrj.fsf@gmail.com> <87tunoyzzd.fsf@gmx.de> <87eeerby1n.fsf@gmail.com> <87a6pfepo6.fsf@gmx.de> <874kflmzn3.fsf@gmail.com> <87wns9glm1.fsf@gmx.de> <87y2co4hto.fsf@gmail.com> <87v97reubc.fsf@gmx.de> <87lf4lkb1w.fsf_-_@gmail.com> <87lf4l91nb.fsf@gmx.de> <87czpxk9mi.fsf@gmail.com> <87h7f99073.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40932"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Augusto Stoffel , emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Aug 28 16:06:52 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mJyyy-000AOj-KH for ged-emacs-devel@m.gmane-mx.org; Sat, 28 Aug 2021 16:06:52 +0200 Original-Received: from localhost ([::1]:49802 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mJyyw-0003II-UK for ged-emacs-devel@m.gmane-mx.org; Sat, 28 Aug 2021 10:06:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53910) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJyxl-0002ZE-8g for emacs-devel@gnu.org; Sat, 28 Aug 2021 10:05:37 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:27138) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJyxd-0005Uu-1W for emacs-devel@gnu.org; Sat, 28 Aug 2021 10:05:36 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id DDEE1440603; Sat, 28 Aug 2021 10:05:26 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 9CA4E440139; Sat, 28 Aug 2021 10:05:25 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1630159525; bh=g8Aor4vmaiflee7C8crp7I6eh7AFqJYnQKKJdG1K5sw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=VILq6xbFuuTTlaviXsvIvPMWxxn8PE7ZIfJauDG1q9LMupbsgKssmEltX2FRhQj6N rTeNj+TNmZ5JiXaDtZeV2x9iYAgjKQpzc/S6Afy6eYnt6ITjqbkQr3g8LClyxuRlFr HpHbdvGhXHM2pw5SUAxKwmAo2UYoyB727IyTLzm1OucFAdNpYXkbg5m85EVwydaV8u brVJNXA8xzp97D63O+gjidAPjMGcD6JJKWWCke1UgJoCafQQYKrJVm0E0SLw+2km25 QM+2bR3CVQpamluaXXxBIlbmleNJG3s/32lFRBX5x9KzVQJAQqRMVEffatQoGUseQf qV6Jw/16539EA== Original-Received: from alfajor (unknown [104.247.244.135]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 6A7D71203CF; Sat, 28 Aug 2021 10:05:25 -0400 (EDT) In-Reply-To: <87h7f99073.fsf@gmx.de> (Michael Albinus's message of "Sat, 28 Aug 2021 15:18:56 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:273304 Archived-At: Michael Albinus [2021-08-28 15:18:56] wrote: > Augusto Stoffel writes: > >>> W/o further reading, this cannot be right. Elements of >>> `process-environment' have always the syntax "VAR=VALUE". You add only a >>> VALUE (`exec-path') in `bufferenv'. I understand your intention, using >>> `bufferenv' as transportation vehicle, but I believe this is >>> mis-designed, and good for trouble. If not now, then later. >> >> This is a temporary, lexical variable that is inaccessible to the user >> directly. It's "destructured" again in the next hunk of the patch. > > I've seen this. But we shall avoid this dirty kind of programming, even > if it is internal only. I don't see anything dirty about it. I think you're just getting confused by the fact that the code uses `cons` to build a pair of a string and a list and you read it as adding add a string to the list. Maybe the confusion would be avoided by switching the two (i.e. use `(cons process-environment exec-path)`). Stefan