From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: ELPA: New package: svg-lib Date: Mon, 27 Sep 2021 16:03:48 -0400 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12459"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: "Nicolas P. Rougier (inria)" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Sep 27 22:09:11 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mUww2-00034l-4Y for ged-emacs-devel@m.gmane-mx.org; Mon, 27 Sep 2021 22:09:10 +0200 Original-Received: from localhost ([::1]:44528 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mUww0-0001Kr-Kk for ged-emacs-devel@m.gmane-mx.org; Mon, 27 Sep 2021 16:09:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36622) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mUwrZ-0004fh-Lq for emacs-devel@gnu.org; Mon, 27 Sep 2021 16:04:35 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:27716) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mUwrV-0003iu-PI for emacs-devel@gnu.org; Mon, 27 Sep 2021 16:04:31 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id BC48810021B; Mon, 27 Sep 2021 16:04:27 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id CF8F0100134; Mon, 27 Sep 2021 16:04:25 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1632773065; bh=FUMoQQVTEVrwYT6Sf8Wn89PJ8WBJB+bjc/q9SBKwjQk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=RaFFQoRHmIA4RouQYboo9G94M0PKl4vji8zfuosnD30M4LHW/tM0mjjiMxwcC5sEm mCyMZcsvO7vYBe7wrUNcReVZeY/tGXFHwWRVgT7mh13OCiL4UTkW1/4+G6bxgfqdY0 UHSeP8B4mjQqpr1YZt36dVA2HdkMyx2EA8nRIP78QncVAuawbqR0fDTWGrbmxZtyox FrEBG73HK7XliPJtZQrfrj6h3P5YqhjFRbysWC241BpfAllnHJZC/BgKxdtpNbtdm4 Az9eT8NPjDsQHrOFJb0S+/wjCGJrQyP4zYH2UGPr4fSkDT+J8hrG+5U7ahhDKIVoVk WAqRYZs9KFTJg== Original-Received: from alfajor (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id BD43B120533; Mon, 27 Sep 2021 16:04:25 -0400 (EDT) In-Reply-To: (Nicolas P. Rougier's message of "Mon, 27 Sep 2021 15:49:16 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:275611 Archived-At: Nicolas P. Rougier (inria) [2021-09-27 15:49:16] wrote: > generating various SVG tags, progress bars, progress pies & icons that fi= ts > nicely in a text buffer. > > The library is hosted at https://github.com/rougier/svg-lib and the README > displays what it looks like. Looks good to me. Before I add it, tho: - Please make sure (from now on) that contributors have signed paperwork (or that the sum of their contributions stays within the "trivial" limit) before you accept their patches. - The svg-lib-demo.el lacks a `;; Copyright (C) 2021 Free Software Foundati= on, Inc.` Also, see below the warnings I got when trying to byte-compile it. And while I'm here I'd recommend allowing the users to *load* svg-lib.el even if (not (image-type-available-p 'svg)) and only signal an error when they actually use the library. Stefan % make packages/svg-lib emacs --batch -Q -l admin/elpa-admin.el \ -f elpaa-batch-pkg-spec-make-dependencies .pkg-descs.mk Generating description file packages/svg-lib/svg-lib-pkg.el emacs --batch -l admin/elpa-admin.el \ -f elpaa-batch-generate-autoloads packages/svg-lib/svg-lib-autoloa= ds.el INFO Scraping files for svg-lib-autoloads.el...=20 INFO Scraping files for svg-lib-autoloads.el...done Byte compiling packages/svg-lib/svg-lib-demo.el Unable to activate package =E2=80=98tuareg=E2=80=99. Required package =E2=80=98caml-3.12.0.1=E2=80=99 is unavailable Unable to activate package =E2=80=98use-package=E2=80=99. Required package =E2=80=98bind-key-2.4=E2=80=99 is unavailable Unable to activate package =E2=80=98modus-vivendi-theme=E2=80=99. Required package =E2=80=98modus-themes-1.2.4=E2=80=99 is unavailable Unable to activate package =E2=80=98modus-operandi-theme=E2=80=99. Required package =E2=80=98modus-themes-1.2.4=E2=80=99 is unavailable In toplevel form: packages/svg-lib/svg-lib-demo.el:41:3:Warning: reference to free variable =E2=80=98GNU=E2=80=99 packages/svg-lib/svg-lib-demo.el:41:7:Warning: reference to free variable =E2=80=98Emacs=E2=80=99 Byte compiling packages/svg-lib/svg-lib.el Unable to activate package =E2=80=98tuareg=E2=80=99. Required package =E2=80=98caml-3.12.0.1=E2=80=99 is unavailable Unable to activate package =E2=80=98use-package=E2=80=99. Required package =E2=80=98bind-key-2.4=E2=80=99 is unavailable Unable to activate package =E2=80=98modus-vivendi-theme=E2=80=99. Required package =E2=80=98modus-themes-1.2.4=E2=80=99 is unavailable Unable to activate package =E2=80=98modus-operandi-theme=E2=80=99. Required package =E2=80=98modus-themes-1.2.4=E2=80=99 is unavailable In toplevel form: packages/svg-lib/svg-lib.el:91:1:Warning: defcustom for =E2=80=98svg-lib-icon-collections=E2=80=99 provides redundant :group packages/svg-lib/svg-lib.el:115:1:Warning: defcustom for =E2=80=98svg-lib-i= cons-dir=E2=80=99 provides redundant :group packages/svg-lib/svg-lib.el:152:1:Warning: defcustom for =E2=80=98svg-lib-style-default=E2=80=99 provides redundant :group In svg-lib-style: packages/svg-lib/svg-lib.el:177:44:Warning: Unused lexical variable `value' In svg-lib-tag: packages/svg-lib/svg-lib.el:214:40:Warning: Unused lexical variable `width' packages/svg-lib/svg-lib.el:217:40:Warning: Unused lexical variable `scale' packages/svg-lib/svg-lib.el:229:33:Warning: Unused lexical variable `tag-char-height' In svg-lib-progress-pie: packages/svg-lib/svg-lib.el:267:40:Warning: Unused lexical variable `width' packages/svg-lib/svg-lib.el:269:40:Warning: Unused lexical variable `scale' packages/svg-lib/svg-lib.el:274:40:Warning: Unused lexical variable `font-weight' packages/svg-lib/svg-lib.el:280:66:Warning: Unused lexical variable `ascent' packages/svg-lib/svg-lib.el:281:33:Warning: Unused lexical variable `tag-char-width' packages/svg-lib/svg-lib.el:282:33:Warning: Unused lexical variable `tag-char-height' packages/svg-lib/svg-lib.el:289:27:Warning: Unused lexical variable `tag-x' packages/svg-lib/svg-lib.el:299:33:Warning: reference to free variable =E2= =80=98pi=E2=80=99 In svg-lib-progress-bar: packages/svg-lib/svg-lib.el:340:40:Warning: Unused lexical variable `scale' packages/svg-lib/svg-lib.el:345:40:Warning: Unused lexical variable `font-weight' packages/svg-lib/svg-lib.el:351:66:Warning: Unused lexical variable `ascent' packages/svg-lib/svg-lib.el:352:33:Warning: Unused lexical variable `tag-char-width' packages/svg-lib/svg-lib.el:353:33:Warning: Unused lexical variable `tag-char-height' In svg-lib-icon: packages/svg-lib/svg-lib.el:427:40:Warning: Unused lexical variable `font-size' packages/svg-lib/svg-lib.el:428:40:Warning: Unused lexical variable `font-family' packages/svg-lib/svg-lib.el:429:40:Warning: Unused lexical variable `font-weight' packages/svg-lib/svg-lib.el:444:20:Warning: string-to-number quoted with ' rather than with #' packages/svg-lib/svg-lib.el:471:35:Warning: Unused lexical variable `fill' In svg-lib-button: packages/svg-lib/svg-lib.el:508:28:Warning: Unused lexical variable `box-width' packages/svg-lib/svg-lib.el:509:36:Warning: Unused lexical variable `box-height' packages/svg-lib/svg-lib.el:515:33:Warning: Unused lexical variable `tag-char-height' packages/svg-lib/svg-lib.el:557:35:Warning: Unused lexical variable `fill' In end of data: packages/svg-lib/svg-lib.el:167:18:Warning: the function =E2=80=98color-rgb= -to-hex=E2=80=99 is not known to be defined.