From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Request: Please add a prompt to read-event Date: Tue, 21 Dec 2021 10:17:54 -0500 Message-ID: References: <87o85exsyv.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37976"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: "T.V Raman" , emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 21 16:38:01 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mzhDE-0009hK-Ux for ged-emacs-devel@m.gmane-mx.org; Tue, 21 Dec 2021 16:38:01 +0100 Original-Received: from localhost ([::1]:34350 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mzhDD-0000V3-NP for ged-emacs-devel@m.gmane-mx.org; Tue, 21 Dec 2021 10:37:59 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:47986) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mzgu7-0006aS-JW for emacs-devel@gnu.org; Tue, 21 Dec 2021 10:18:15 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:61664) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mzgu3-0000h0-Q4 for emacs-devel@gnu.org; Tue, 21 Dec 2021 10:18:15 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 02D1B100221; Tue, 21 Dec 2021 10:17:58 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 5B228100142; Tue, 21 Dec 2021 10:17:56 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1640099876; bh=NRP3NCXRBciWhws7aobBZ3aCMJCFzzbqwEYrvZyuj4M=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=XskSt+KChd5dABC9A+i9sbmtFYX//teXc3CeXHjF358KnJTFqTdoPhut88f0i0zYk 5aexSxpTh7StxI3+H2nloLvgBYLis54U6pyMidMvpjR6GwJeIC49blUNpgO61cgRzs Xk76A2X/zISG4NiZpCHmxL3pkcILHLGonOHwLhpJjOiUm3iXHSApoMf9eU9IIbLhqM zTy83a/wCDKutlEX5F4Ik6MNGQRIkIeeL8Uh0knt99enYmoL979gtFP610j0zMcWjM JdZDI+A8PjdK3Zt8DgztOywvfTDcTVTUDI9qtjad0ZaDG17zLSL/9mbyaZx0yboVjo tmFj3gdVnZjOw== Original-Received: from pastel (unknown [216.154.30.173]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 2B9C2120284; Tue, 21 Dec 2021 10:17:56 -0500 (EST) In-Reply-To: <87o85exsyv.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 18 Dec 2021 08:39:04 +0100") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:282597 Archived-At: Lars Ingebrigtsen [2021-12-18 08:39:04] wrote: > "T.V Raman" writes: > >> Emacspeak advices read-event and read-char to speak their >> prompt. There are a few places in Emacs where read-event and/or >> read-char are called without a prompt; e.g. disabled-command-function >> >> Could we perhaps fix this? > > [...] > >> (message "Type y, n, ! or SPC (the space bar): ") >> (let ((cursor-in-echo-area t)) >> (while (progn (setq char (read-event)) >> (or (not (numberp char)) >> (not (memq (downcase char) >> '(?! ?y ?n ?\s ?\C-g))))) >> (ding) >> (message "Please type y, n, ! or SPC (the space bar): ")))) > > Hm... that is pretty odd. Why is it using `message' here instead of > just using that string as the prompt to `read-event'? This code dates back to 1989. It would benefit from a bit of modernization, such as making it use `read-multiple-choice`. Stefan