From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Zero byte-compiler warnings in the test suite Date: Wed, 22 Dec 2021 12:40:54 -0500 Message-ID: References: <87ilvigl3z.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4455"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 22 19:03:52 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n05xw-0000yk-Dp for ged-emacs-devel@m.gmane-mx.org; Wed, 22 Dec 2021 19:03:52 +0100 Original-Received: from localhost ([::1]:54818 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n05xv-0006wB-0i for ged-emacs-devel@m.gmane-mx.org; Wed, 22 Dec 2021 13:03:51 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:52808) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n05cA-0001vG-LY for emacs-devel@gnu.org; Wed, 22 Dec 2021 12:41:22 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:36864) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n05by-0002hc-VE for emacs-devel@gnu.org; Wed, 22 Dec 2021 12:41:12 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 98A22805EF; Wed, 22 Dec 2021 12:41:08 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 9578B80552; Wed, 22 Dec 2021 12:41:02 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1640194862; bh=dPd/iTLZoTt6C/wJjZtbbW3XBluNC70FepsHqIS4auc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=JRKWKVl1YZltJwhmu8JAj17Z+q/KJ58X0qO4l+o8H7sleErsC7OBgI4LcW6Eh4s+2 R5GUZbDYTrm6Lv5Xr+ldip9SNur+kzZLmOm0flU7fX6ewRjuB1mK1y1Og49zeYOh47 ldNdXbIMgVZ29X/1MMbsOTDAyDvGFJdVzloIAQxALAcsGGJk1Sebr8dTmdZjuvSypK vNRO35yQIqaS2eIH119DqpXISIprNOm6SMX3c/zXcP9hSXWPrPmCVXc61sHHJTx7Dc eaNemBcmtAUKNF4KSJt1+BE4e3nE8rBtRv1OVeZt344n2htZNWE9XxTDy7f3iBCP/9 g0VEowCkoP6dA== Original-Received: from pastel (unknown [216.154.30.173]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 409161201E1; Wed, 22 Dec 2021 12:41:02 -0500 (EST) In-Reply-To: (Stefan Kangas's message of "Tue, 21 Dec 2021 21:07:52 -0800") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:282808 Archived-At: >> The test expects the error to be signal'd at run time whereas the >> compiler macro prefers to signal the error right away. >> As a bias observer, I'd suggest to fix the test rather than the compiler >> macro ;-) > > How do we usually test compiler macros? I guess we should create a > separate file and try to byte-compile it? I'd do something like (should-error (macroexpand-all '(pcase ...))) -- Stefan