* Re: emacs-28 bc63651588: Make all vc-*-responsible-p functions return a string
[not found] ` <20220414134650.18AF7C01684@vcs2.savannah.gnu.org>
@ 2022-04-14 14:17 ` Stefan Monnier
2022-04-14 14:51 ` Lars Ingebrigtsen
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Monnier @ 2022-04-14 14:17 UTC (permalink / raw)
To: emacs-devel; +Cc: Lars Ingebrigtsen
> Make all vc-*-responsible-p functions return a string
>
> * lisp/vc/vc-sccs.el (vc-sccs-responsible-p):
> * lisp/vc/vc-rcs.el (vc-rcs-responsible-p):
> * lisp/vc/vc-dav.el (vc-dav-responsible-p):
> * lisp/vc/vc-cvs.el (vc-cvs-responsible-p): Return a file name
> instead of t when we get a match (which is what
> vc-backend-for-registration expects) (bug#51800).
>
> This fixes the regression reported in bug#54935.
Could you change the docstrings accordingly (they all say just
"non-nil") and more importantly the doc of `responsible-p` in the header
of `vc.el` which still says:
;; - responsible-p (file)
;;
;; Return non-nil if this backend considers itself "responsible" for
;; FILE, which can also be a directory. This function is used to find
;; out what backend to use for registration of new files and for things
;; like change log generation. The default implementation always
;; returns nil.
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: emacs-28 bc63651588: Make all vc-*-responsible-p functions return a string
2022-04-14 14:17 ` emacs-28 bc63651588: Make all vc-*-responsible-p functions return a string Stefan Monnier
@ 2022-04-14 14:51 ` Lars Ingebrigtsen
0 siblings, 0 replies; 2+ messages in thread
From: Lars Ingebrigtsen @ 2022-04-14 14:51 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> Could you change the docstrings accordingly (they all say just
> "non-nil") and more importantly the doc of `responsible-p` in the header
> of `vc.el` which still says:
>
> ;; - responsible-p (file)
> ;;
> ;; Return non-nil if this backend considers itself "responsible" for
> ;; FILE, which can also be a directory. This function is used to find
> ;; out what backend to use for registration of new files and for things
> ;; like change log generation. The default implementation always
> ;; returns nil.
Yup; now done.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-14 14:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <164994400978.31398.12766178338959012907@vcs2.savannah.gnu.org>
[not found] ` <20220414134650.18AF7C01684@vcs2.savannah.gnu.org>
2022-04-14 14:17 ` emacs-28 bc63651588: Make all vc-*-responsible-p functions return a string Stefan Monnier
2022-04-14 14:51 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).