From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Cc: Lars Ingebrigtsen <larsi@gnus.org>
Subject: Re: emacs-28 bc63651588: Make all vc-*-responsible-p functions return a string
Date: Thu, 14 Apr 2022 10:17:14 -0400 [thread overview]
Message-ID: <jwvilrb92ev.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20220414134650.18AF7C01684@vcs2.savannah.gnu.org> (Lars Ingebrigtsen's message of "Thu, 14 Apr 2022 09:46:49 -0400 (EDT)")
> Make all vc-*-responsible-p functions return a string
>
> * lisp/vc/vc-sccs.el (vc-sccs-responsible-p):
> * lisp/vc/vc-rcs.el (vc-rcs-responsible-p):
> * lisp/vc/vc-dav.el (vc-dav-responsible-p):
> * lisp/vc/vc-cvs.el (vc-cvs-responsible-p): Return a file name
> instead of t when we get a match (which is what
> vc-backend-for-registration expects) (bug#51800).
>
> This fixes the regression reported in bug#54935.
Could you change the docstrings accordingly (they all say just
"non-nil") and more importantly the doc of `responsible-p` in the header
of `vc.el` which still says:
;; - responsible-p (file)
;;
;; Return non-nil if this backend considers itself "responsible" for
;; FILE, which can also be a directory. This function is used to find
;; out what backend to use for registration of new files and for things
;; like change log generation. The default implementation always
;; returns nil.
Stefan
next parent reply other threads:[~2022-04-14 14:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <164994400978.31398.12766178338959012907@vcs2.savannah.gnu.org>
[not found] ` <20220414134650.18AF7C01684@vcs2.savannah.gnu.org>
2022-04-14 14:17 ` Stefan Monnier [this message]
2022-04-14 14:51 ` emacs-28 bc63651588: Make all vc-*-responsible-p functions return a string Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvilrb92ev.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).