From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Sean Whitton <spwhitton@spwhitton.name>
Cc: Robert Pluim <rpluim@gmail.com>,
emacs-devel@gnu.org, 55257-submitter@debbugs.gnu.org
Subject: Re: master f2d2fe6fc8: server-execute: Initialize the *scratch* buffer
Date: Fri, 06 May 2022 07:34:40 -0400 [thread overview]
Message-ID: <jwvilqic32v.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87y1zf39x7.fsf@melete.silentflame.com> (Sean Whitton's message of "Thu, 05 May 2022 15:13:24 -0700")
> + (if-let ((scratch (get-buffer "*scratch*")))
> + scratch
A.k.a
(or (get-buffer "*scratch*")
> (defun scratch-buffer ()
> "Switch to the \*scratch\* buffer.
> If the buffer doesn't exist, create it first."
> (interactive)
> - (if (get-buffer "*scratch*")
> - (pop-to-buffer-same-window "*scratch*")
> - (pop-to-buffer-same-window (get-buffer-create "*scratch*"))
> - (when initial-scratch-message
> - (insert initial-scratch-message))
> - (funcall initial-major-mode)))
> + (pop-to-buffer-same-window (get-initial-buffer-create)))
I think the new function can be considered "internal", and I think it
would be better for its name to use "scratch-buffer" as a prefix, so
maybe `scratch-buffer--create`?
Other than that, it looks good to me, thank you very much.
Stefan
next prev parent reply other threads:[~2022-05-06 11:34 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <165162665935.26821.8964921720746152690@vcs2.savannah.gnu.org>
[not found] ` <20220504011059.9F667C009A8@vcs2.savannah.gnu.org>
2022-05-04 2:14 ` master f2d2fe6fc8: server-execute: Initialize the *scratch* buffer Stefan Monnier
2022-05-04 5:40 ` Sean Whitton
2022-05-04 12:47 ` Stefan Monnier
2022-05-04 14:23 ` Sean Whitton
2022-05-04 14:34 ` Robert Pluim
2022-05-04 14:46 ` Sean Whitton
2022-05-04 14:56 ` Robert Pluim
2022-05-04 14:42 ` Stefan Monnier
2022-05-04 15:41 ` Sean Whitton
2022-05-04 16:26 ` Stefan Monnier
2022-05-05 22:07 ` Sean Whitton
2022-05-05 22:13 ` Sean Whitton
2022-05-06 11:34 ` Stefan Monnier [this message]
2022-05-06 19:20 ` Sean Whitton
2022-05-06 19:24 ` Lars Ingebrigtsen
2022-05-06 5:40 ` Eli Zaretskii
2022-05-06 19:26 ` Sean Whitton
2022-05-07 5:30 ` Eli Zaretskii
2022-05-07 13:51 ` Stefan Monnier
2022-05-07 14:12 ` Eli Zaretskii
2022-05-07 16:29 ` Sean Whitton
2022-05-07 16:41 ` Eli Zaretskii
2022-05-07 17:02 ` Sean Whitton
2022-05-06 7:41 ` Juri Linkov
2022-05-06 19:28 ` Sean Whitton
2022-05-08 0:27 ` bug#55257: " Sean Whitton
2022-05-09 18:11 ` Stefan Monnier
2022-05-10 1:49 ` Sean Whitton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvilqic32v.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=55257-submitter@debbugs.gnu.org \
--cc=emacs-devel@gnu.org \
--cc=rpluim@gmail.com \
--cc=spwhitton@spwhitton.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).