unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: master edd11a2c6e 1/2: Update comments in some X code
@ 2022-05-27 12:18 Eli Zaretskii
  2022-05-27 13:13 ` Po Lu
  2022-05-27 13:53 ` x-color-cache-bucket-size (was: master edd11a2c6e 1/2: Update comments in some X code) Stefan Monnier
  0 siblings, 2 replies; 9+ messages in thread
From: Eli Zaretskii @ 2022-05-27 12:18 UTC (permalink / raw)
  To: Po Lu; +Cc: emacs-devel

> +  DEFVAR_INT ("x-color-cache-bucket-size", x_color_cache_bucket_size,
> +    doc: /* Most buckets allowed per display in the internal color cache.
               ^^^^^^^^^^^^
You meant "Max number of buckets", right?



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: master edd11a2c6e 1/2: Update comments in some X code
  2022-05-27 12:18 master edd11a2c6e 1/2: Update comments in some X code Eli Zaretskii
@ 2022-05-27 13:13 ` Po Lu
  2022-05-27 14:20   ` Eli Zaretskii
  2022-05-27 15:38   ` tomas
  2022-05-27 13:53 ` x-color-cache-bucket-size (was: master edd11a2c6e 1/2: Update comments in some X code) Stefan Monnier
  1 sibling, 2 replies; 9+ messages in thread
From: Po Lu @ 2022-05-27 13:13 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: emacs-devel

Eli Zaretskii <eliz@gnu.org> writes:

> You meant "Max number of buckets", right?

Yes, but that makes the first line longer than 69 characters, which I
think is the limit.  Don't "most" and "max number of" mean the same here
anyway?




^ permalink raw reply	[flat|nested] 9+ messages in thread

* x-color-cache-bucket-size (was: master edd11a2c6e 1/2: Update comments in some X code)
  2022-05-27 12:18 master edd11a2c6e 1/2: Update comments in some X code Eli Zaretskii
  2022-05-27 13:13 ` Po Lu
@ 2022-05-27 13:53 ` Stefan Monnier
  2022-05-28  0:38   ` x-color-cache-bucket-size Po Lu
  1 sibling, 1 reply; 9+ messages in thread
From: Stefan Monnier @ 2022-05-27 13:53 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: Po Lu, emacs-devel

>> +  DEFVAR_INT ("x-color-cache-bucket-size", x_color_cache_bucket_size,
>> +    doc: /* Most buckets allowed per display in the internal color cache.

Why do we need to expose this?


        Stefan




^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: master edd11a2c6e 1/2: Update comments in some X code
  2022-05-27 13:13 ` Po Lu
@ 2022-05-27 14:20   ` Eli Zaretskii
  2022-05-28  0:39     ` Po Lu
  2022-05-27 15:38   ` tomas
  1 sibling, 1 reply; 9+ messages in thread
From: Eli Zaretskii @ 2022-05-27 14:20 UTC (permalink / raw)
  To: Po Lu; +Cc: emacs-devel

> From: Po Lu <luangruo@yahoo.com>
> Cc: emacs-devel@gnu.org
> Date: Fri, 27 May 2022 21:13:24 +0800
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > You meant "Max number of buckets", right?
> 
> Yes, but that makes the first line longer than 69 characters, which I
> think is the limit.

Why 69?  The limit is 79.

> Don't "most" and "max number of" mean the same here anyway?

No.  "Most buckets" is simply incorrect and confusing English.



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: master edd11a2c6e 1/2: Update comments in some X code
  2022-05-27 13:13 ` Po Lu
  2022-05-27 14:20   ` Eli Zaretskii
@ 2022-05-27 15:38   ` tomas
  1 sibling, 0 replies; 9+ messages in thread
From: tomas @ 2022-05-27 15:38 UTC (permalink / raw)
  To: emacs-devel

[-- Attachment #1: Type: text/plain, Size: 915 bytes --]

On Fri, May 27, 2022 at 09:13:24PM +0800, Po Lu wrote:
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > You meant "Max number of buckets", right?
> 
> Yes, but that makes the first line longer than 69 characters, which I
> think is the limit.  Don't "most" and "max number of" mean the same here
> anyway?

Oh, as a non-native speaker I feel your pain :)

"Most buckets" means given a fixed set of buckets, their majority.
Whereas the maximum number of buckets means "you can't have more
than so-many buckets". So the first is a subset of some existing
set of buckets (usually with a property characterising it), whereas
the second is a number.

As in "most people in this elevator wear a tie", as opposed to
"the maximum number of people in this elevator is 69".

If you are short of space, "max buckets" or even "max. buckets"
might do, although it isn't really good English.

Cheers
-- 
t

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: x-color-cache-bucket-size
  2022-05-27 13:53 ` x-color-cache-bucket-size (was: master edd11a2c6e 1/2: Update comments in some X code) Stefan Monnier
@ 2022-05-28  0:38   ` Po Lu
  2022-05-28  0:43     ` x-color-cache-bucket-size Stefan Monnier
  0 siblings, 1 reply; 9+ messages in thread
From: Po Lu @ 2022-05-28  0:38 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: Eli Zaretskii, emacs-devel

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> Why do we need to expose this?

Debugging.  It's not something users are supposed to make use of.



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: master edd11a2c6e 1/2: Update comments in some X code
  2022-05-27 14:20   ` Eli Zaretskii
@ 2022-05-28  0:39     ` Po Lu
  0 siblings, 0 replies; 9+ messages in thread
From: Po Lu @ 2022-05-28  0:39 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: emacs-devel

Eli Zaretskii <eliz@gnu.org> writes:

> No.  "Most buckets" is simply incorrect and confusing English.

Thanks.  I'll correct that then.



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: x-color-cache-bucket-size
  2022-05-28  0:38   ` x-color-cache-bucket-size Po Lu
@ 2022-05-28  0:43     ` Stefan Monnier
  2022-05-28  6:01       ` x-color-cache-bucket-size Eli Zaretskii
  0 siblings, 1 reply; 9+ messages in thread
From: Stefan Monnier @ 2022-05-28  0:43 UTC (permalink / raw)
  To: Po Lu; +Cc: Eli Zaretskii, emacs-devel

Po Lu [2022-05-28 08:38:31] wrote:
> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> Why do we need to expose this?
> Debugging.  It's not something users are supposed to make use of.

I usually give those kinds of variables a name that makes it more clear,
to try and avoid any surprise later on.


        Stefan




^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: x-color-cache-bucket-size
  2022-05-28  0:43     ` x-color-cache-bucket-size Stefan Monnier
@ 2022-05-28  6:01       ` Eli Zaretskii
  0 siblings, 0 replies; 9+ messages in thread
From: Eli Zaretskii @ 2022-05-28  6:01 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: luangruo, emacs-devel

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: Eli Zaretskii <eliz@gnu.org>,  emacs-devel@gnu.org
> Date: Fri, 27 May 2022 20:43:04 -0400
> 
> Po Lu [2022-05-28 08:38:31] wrote:
> > Stefan Monnier <monnier@iro.umontreal.ca> writes:
> >> Why do we need to expose this?
> > Debugging.  It's not something users are supposed to make use of.
> 
> I usually give those kinds of variables a name that makes it more clear,
> to try and avoid any surprise later on.

It should be enough to say something like "Internal use only."



^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2022-05-28  6:01 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-27 12:18 master edd11a2c6e 1/2: Update comments in some X code Eli Zaretskii
2022-05-27 13:13 ` Po Lu
2022-05-27 14:20   ` Eli Zaretskii
2022-05-28  0:39     ` Po Lu
2022-05-27 15:38   ` tomas
2022-05-27 13:53 ` x-color-cache-bucket-size (was: master edd11a2c6e 1/2: Update comments in some X code) Stefan Monnier
2022-05-28  0:38   ` x-color-cache-bucket-size Po Lu
2022-05-28  0:43     ` x-color-cache-bucket-size Stefan Monnier
2022-05-28  6:01       ` x-color-cache-bucket-size Eli Zaretskii

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).