unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: master 52e527a02f 2/2: Make ?\LF generate 10, not -1 (bug#55738)
       [not found] ` <20220602145723.DD058C009A8@vcs2.savannah.gnu.org>
@ 2022-06-03  1:22   ` Stefan Monnier
  2022-06-03  9:34     ` Mattias Engdegård
  0 siblings, 1 reply; 2+ messages in thread
From: Stefan Monnier @ 2022-06-03  1:22 UTC (permalink / raw)
  To: emacs-devel; +Cc: Mattias Engdegård

>     Make ?\LF generate 10, not -1 (bug#55738)

I think I'd prefer if it signaled an error.


        Stefan




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: master 52e527a02f 2/2: Make ?\LF generate 10, not -1 (bug#55738)
  2022-06-03  1:22   ` master 52e527a02f 2/2: Make ?\LF generate 10, not -1 (bug#55738) Stefan Monnier
@ 2022-06-03  9:34     ` Mattias Engdegård
  0 siblings, 0 replies; 2+ messages in thread
From: Mattias Engdegård @ 2022-06-03  9:34 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: emacs-devel

3 juni 2022 kl. 03.22 skrev Stefan Monnier <monnier@iro.umontreal.ca>:

>>    Make ?\LF generate 10, not -1 (bug#55738)
> 
> I think I'd prefer if it signaled an error.

I would, too -- done. There is no way such code could be anything other than a mistake.
And look what turns up during bootstrapping:

(defvar idlwave-comment-indent-char ?\

The idlwave.el history provides some entertainment:

f32b3b911bb Carsten Dominik    1999-12-20  ?\SPC   (initial commit)
775591f7677 Juanma Barranquero 2002-10-18  ?\SPC -> ?\LF
93af03f0a1c Markus Rost        2003-07-21  ?\LF  -> ?\s
52a244ebe2b J.D. Smith         2004-11-17  ?\s   -> ?\SPC
b6a97790db0 Juanma Barranquero 2005-06-16  ?\SPC -> ?\LF
3938cb82d0f J.D. Smith         2005-07-04  ?\LF  -> ?\SPC
31b58798cba Juanma Barranquero 2005-07-04  ?\SPC -> ?\LF
f66f03dec52 J.D. Smith         2006-04-06  ?\LF  -> ?\SPC
4b1aaa8b07c Paul Eggert        2006-09-12  ?\SPC -> ?\LF

Not only is this a strong argument supporting your preference for an error here, it's also an indication that automatically removing trailing spaces isn't necessarily a wonderful idea (I never do that myself).

(This particular variable hasn't been used for some time so the damage is limited in this case.)




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-06-03  9:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <165418184336.1712.15298047428426189239@vcs2.savannah.gnu.org>
     [not found] ` <20220602145723.DD058C009A8@vcs2.savannah.gnu.org>
2022-06-03  1:22   ` master 52e527a02f 2/2: Make ?\LF generate 10, not -1 (bug#55738) Stefan Monnier
2022-06-03  9:34     ` Mattias Engdegård

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).