From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 49e06183f5 1/3: Allow REQUIRE-MATCH to be a function Date: Mon, 13 Jun 2022 12:37:23 -0400 Message-ID: References: <165484935985.12525.14065631018362412932@vcs2.savannah.gnu.org> <20220610082240.A7222C01683@vcs2.savannah.gnu.org> <87pmjfsc1v.fsf@gnus.org> <874k0rqiwh.fsf@gnus.org> <87tu8qp5hy.fsf@gnus.org> <8735g8oj7z.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7377"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org, Daniel Mendler To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jun 13 18:38:43 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o0n5O-0001js-6c for ged-emacs-devel@m.gmane-mx.org; Mon, 13 Jun 2022 18:38:42 +0200 Original-Received: from localhost ([::1]:50844 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o0n5M-0003vP-Pc for ged-emacs-devel@m.gmane-mx.org; Mon, 13 Jun 2022 12:38:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50204) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o0n4F-000256-BD for emacs-devel@gnu.org; Mon, 13 Jun 2022 12:37:31 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:58142) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o0n4C-0001fI-Cg for emacs-devel@gnu.org; Mon, 13 Jun 2022 12:37:30 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 2CDD544092C; Mon, 13 Jun 2022 12:37:26 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id C8C0444091E; Mon, 13 Jun 2022 12:37:24 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1655138244; bh=VEp7FDLITmsfJ/rek7tn09KxQDaMdSdXWRV4r6tBVM0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=gW4GgyISNkdm9etlOo35WpTIu08T0Vxdn+INU39XABTdPKaA7oCDEECH1QrD5NTRk /R6fmCs4R+uTf3Q7R4gWF+yB3kgxFGLiYgZbU4JUwucCpWsJHK7wUMfiQwJJAIhFO4 btnjLDPiMDvXYVaqf9kVbha5JTf3ltRB4vkX28VqjYIazknTo4Ihmfwj1KN5Nd3z6m XA4PZo7Iy/ey4/jAujMJZB4w34AZQ7EqiQ4i4xVKrkdWeFRLUMTprCdCOALkygVC+w s/lJ17spJdwZAC+VLYlQEFLbzEArJ2W+27vN/qk+iOSYgxr2PqEQa4rUWxnyBgTubx d29QReySCvtdw== Original-Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 9592D1204DA; Mon, 13 Jun 2022 12:37:24 -0400 (EDT) In-Reply-To: <8735g8oj7z.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 13 Jun 2022 14:12:32 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:291152 Archived-At: Lars Ingebrigtsen [2022-06-13 14:12:32] wrote: > Stefan Monnier writes: >> Look at the code that is run when (functionp >> minibuffer-completion-confirm) is nil, and you'll see there's a lot more >> to do than that if you want to reproduce the behavior faithfully. > > Yeah, those are the subtleties of the completion machinery that I'm sure > I don't understand. :-) And in order not to have to understand them, you should move this code out into its own function and call it in the same way that `minibuffer-completion-confirm` is called (such that `minibuffer-completion-confirm` can simply call this function to reproduce that default behavior). Stefan