From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: feature/package+vc 04c4c578c7 3/4: Allow for packages to be installed directly from VCS Date: Sat, 22 Oct 2022 10:53:53 -0400 Message-ID: References: <164484721900.31751.1453162457552427931@vcs2.savannah.gnu.org> <87bkqmqpvb.fsf@posteo.net> <871qris3xb.fsf@gnus.org> <877d1aqoc1.fsf@posteo.net> <87edvhqdrb.fsf@gnus.org> <871qrh2hh6.fsf@posteo.net> <87mta5oyec.fsf@gnus.org> <87sfjx10x1.fsf@posteo.net> <875ygsp0ng.fsf@gnus.org> <87h70c9bu4.fsf@posteo.net> <874jw73cjy.fsf@posteo.net> <87edv72z11.fsf@posteo.net> <87czaq1i3k.fsf@posteo.net> <87fsfkhnhm.fsf@posteo.net> <87mt9s47f1.fsf@posteo.net> <871qr0kfeu.fsf@posteo.net> <87ilkcp25k.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32010"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , emacs-devel@gnu.org To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Oct 24 09:09:24 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1omraN-0008CB-ON for ged-emacs-devel@m.gmane-mx.org; Mon, 24 Oct 2022 09:09:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1omgZh-0000iv-91 for ged-emacs-devel@m.gmane-mx.org; Sun, 23 Oct 2022 15:23:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1omFsv-0006H1-GE for emacs-devel@gnu.org; Sat, 22 Oct 2022 10:54:01 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1omFst-00007Z-El for emacs-devel@gnu.org; Sat, 22 Oct 2022 10:54:01 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id DF3C71002F0; Sat, 22 Oct 2022 10:53:56 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 38F7110010F; Sat, 22 Oct 2022 10:53:55 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1666450435; bh=P9/zS7fTacwtLY0C8hYOtbLUOQS8wPTucIIfSHdq860=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Lip9u9fjSX4cw0DMhp0ay8JSFPAdt8sSjQCs7SxEpgnhvMrmw2YANnPCxDIkfTPS6 utG25duZIYbDjxX3w7w9Hkf4TzURYaSLKjf27taFIESkGSsKqjoCwrH9P9STuGZHzC vDdsiEc/MmAOkxvoLDB3X4e+4h6EsZ1/5Ox8rszEU96VPF719R234eeV0lPWlUzX/a zn53hnQLop/b2H7jkNZ7C7cShXkhAGfPWII0MTdiaHuDDLbEJCrOXiNGM4Xbub3L/+ UMjHdi6vcdJUKuufYyhzAkID8HL2+tae59Z+0d0xi1SmwMe25tS/4msN0dCjxObaMs KBrDM9kjvlOhA== Original-Received: from pastel (65-110-220-202.cpe.pppoe.ca [65.110.220.202]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 04AD01207DD; Sat, 22 Oct 2022 10:53:54 -0400 (EDT) In-Reply-To: <87ilkcp25k.fsf@posteo.net> (Philip Kaludercic's message of "Sat, 22 Oct 2022 10:45:43 +0000") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:298349 Archived-At: > That was my mistake, I misremembered that core packages aren't mirrored > in their own branches in elpa.git. I've removed it here: LGTM, thanks! Feel free to push. > + ((and (plist-member (cdr spec) :url) > + (null (plist-get (cdr spec) :url))) > + `((,(car spec) > + :url ,(concat "https://git.sv.gnu.org/git/" elpaa--gitrepo) > + :branch ,(concat elpaa--branch-prefix (car spec)) > + ,@(cdddr spec)))) The `cdddr` presumes the `:url nil` is at the very beginning (which is a valid assumption, indeed), whereas the `plist-member/get` dance tries to deal with the more general case. I think you can simply that to (pcase spec (`(:url nil . ,props) ...) ...) Stefan