unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Possible build configurations
Date: Sat, 20 Jan 2024 15:06:41 -0500	[thread overview]
Message-ID: <jwvil3n3i9b.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <83sf2rswn5.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 20 Jan 2024 20:11:10 +0200")

> The FOO-win features are provided by the corresponding FOO-win.el
> files in lisp/term/, not by FOOterm.c.

Oh, right, I was confusing the `<GUI>` and `<GUI>-win` features.
This said, the `<GUI>-win.el` files are loaded by `loadup.el` only
when the corresponding `<GUI>` is defined and those are defined
in `<GUI>term.c`, so I think the end result is "the same".

> So I'm not sure what you are asking about here.  For example, my
> rading of the code is that 'x and 'xinput2 _can_ coexist with
> 'pgtk-win (but not with any other FOO-win, AFAICT).

Hmm... interesting.  `pgtk-win` is provided by `pgtk-win.el`
which is loaded in loadup via:

    (if (featurep 'pgtk)
        (progn
          (load "pgtk-dnd")
          (load "term/common-win")
          (load "term/pgtk-win")))

so it's only defined if the `pgtk` feature is provided.  In turn

    grep Fprovide.\*pgtk ~/src/emacs/main/src/**/*.[ch]

suggests it's provided only by `pgtkterm.c` and my reading of
`configure.ac` suggests `pgtkterm.c` and `xfns.c` (the file where
`xinput2` and `x` are provided) can't be both linked into the `emacs`
executable at the same time.

Am I missing something?


        Stefan


PS: As for why I'm asking, this is basically to determine if

    ;; FIXME: Yuck!
    (if (or (featurep 'w32-win) (featurep 'ns-win)
            (featurep 'haiku-win) (featurep 'pgtk-win)
            (featurep 'android-win))
        (if (featurep 'xinput2)
            nil
          (unless (featurep 'x)
            t))
      t)

is just a roundabout way to write `t`.




  reply	other threads:[~2024-01-20 20:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-20 17:54 Possible build configurations Stefan Monnier
2024-01-20 18:11 ` Eli Zaretskii
2024-01-20 20:06   ` Stefan Monnier [this message]
2024-01-20 20:16     ` Eli Zaretskii
2024-01-21  0:50 ` Po Lu
2024-01-21  4:13   ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvil3n3i9b.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).