From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Fix vc-svn.el 1.27 when using with GNU Emacs 21.4 Date: Mon, 03 Apr 2006 14:12:33 -0400 Message-ID: References: <1143896976.6765.29.camel@forge.intermeta.de> <1143897048.6765.31.camel@forge.intermeta.de> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1144087996 15513 80.91.229.2 (3 Apr 2006 18:13:16 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 3 Apr 2006 18:13:16 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Apr 03 20:13:16 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FQTXq-0002yS-Gg for ged-emacs-devel@m.gmane.org; Mon, 03 Apr 2006 20:12:55 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FQTXp-0001vT-R6 for ged-emacs-devel@m.gmane.org; Mon, 03 Apr 2006 14:12:53 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FQTXe-0001vO-Mq for emacs-devel@gnu.org; Mon, 03 Apr 2006 14:12:42 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FQTXc-0001sN-CX for emacs-devel@gnu.org; Mon, 03 Apr 2006 14:12:41 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FQTXc-0001s6-6S for emacs-devel@gnu.org; Mon, 03 Apr 2006 14:12:40 -0400 Original-Received: from [132.204.24.67] (helo=mercure.iro.umontreal.ca) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FQTaj-0008EM-8w for emacs-devel@gnu.org; Mon, 03 Apr 2006 14:15:53 -0400 Original-Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 55EB52CE9B2; Mon, 3 Apr 2006 14:12:39 -0400 (EDT) Original-Received: from asado.iro.umontreal.ca (asado.iro.umontreal.ca [132.204.24.84]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id A0981452B; Mon, 3 Apr 2006 14:12:33 -0400 (EDT) Original-Received: by asado.iro.umontreal.ca (Postfix, from userid 20848) id 838EE71553; Mon, 3 Apr 2006 14:12:33 -0400 (EDT) Original-To: hps@intermeta.de In-Reply-To: <1143897048.6765.31.camel@forge.intermeta.de> (Henning Schmiedehausen's message of "Sat, 01 Apr 2006 15:10:48 +0200") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:52371 Archived-At: >> Please apply the attached patch. Its function is obvious. >> As vc-do-command only returns 'nil' or 'error', the status is never 0. >> As a result, vc-svn.el has been broken for a while when using with Emacs >> 21.4. Your change breaks the code under Emacs-CVS where vc-do-command does return the execution status. Emacs-CVS's vc-svn.el is meant to be used with Emacs-CVS and I'm even surprised it works with Emacs-21.4 because it relies on several changes in vc.el that occurred since Emacs-21. Stefan