From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: pop-to-buffer does not change input focus Date: Fri, 21 Apr 2006 17:06:17 -0400 Message-ID: References: <44494739.9010302@soem.dk> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1145653628 11846 80.91.229.2 (21 Apr 2006 21:07:08 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 21 Apr 2006 21:07:08 +0000 (UTC) Cc: David Reitter , Emacs-Devel ' Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Apr 21 23:07:03 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FX2ps-0000p6-Bb for ged-emacs-devel@m.gmane.org; Fri, 21 Apr 2006 23:06:40 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FX2pr-0002CR-Op for ged-emacs-devel@m.gmane.org; Fri, 21 Apr 2006 17:06:39 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FX2pd-0002Bh-Tz for emacs-devel@gnu.org; Fri, 21 Apr 2006 17:06:25 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FX2pc-0002B2-5V for emacs-devel@gnu.org; Fri, 21 Apr 2006 17:06:25 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FX2pc-0002Az-13 for emacs-devel@gnu.org; Fri, 21 Apr 2006 17:06:24 -0400 Original-Received: from [132.204.24.67] (helo=mercure.iro.umontreal.ca) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FX2rF-0004Pa-7E for emacs-devel@gnu.org; Fri, 21 Apr 2006 17:08:05 -0400 Original-Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id EB7102DE901; Fri, 21 Apr 2006 17:06:22 -0400 (EDT) Original-Received: from asado.iro.umontreal.ca (asado.iro.umontreal.ca [132.204.24.84]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id 74E9F452B; Fri, 21 Apr 2006 17:06:17 -0400 (EDT) Original-Received: by asado.iro.umontreal.ca (Postfix, from userid 20848) id 56C25715AB; Fri, 21 Apr 2006 17:06:17 -0400 (EDT) Original-To: Lars Hansen In-Reply-To: <44494739.9010302@soem.dk> (Lars Hansen's message of "Fri, 21 Apr 2006 22:57:29 +0200") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:53212 Archived-At: > Reading the code of Fdisplay_buffer, it seem to me that it ends up > calling Fraise_frame which calls Fmake_frame_visible. So maybe theses > functions has a problem. This is what I see: I think this is all OK: display-buffer is not supposed to select the corresponding window/frame. But in Fpop_to_buffer, we call Fselect_window on the window just displayed by Fdisplay_buffer and *that* should cause the input focus to be set. > BTW, are raise-frame and make-frame-visible supposed to give input focus > to the frame? Not that I know. > The doc strings say nothing. And what is really the difference between > these two functions? A frame's visibility can be "invisible", "iconified", or "visible", and make-frame-visible only influences this. So it doesn't raise the frame. Stefan