From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Error in add-log-iso8601-time-string Date: Wed, 26 Apr 2006 12:42:06 -0400 Message-ID: References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1146069770 9397 80.91.229.2 (26 Apr 2006 16:42:50 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 26 Apr 2006 16:42:50 +0000 (UTC) Cc: Emacs Devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 26 18:42:48 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FYn5v-0005cA-4U for ged-emacs-devel@m.gmane.org; Wed, 26 Apr 2006 18:42:29 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FYn5u-00026C-Ja for ged-emacs-devel@m.gmane.org; Wed, 26 Apr 2006 12:42:26 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FYn5k-000267-9j for emacs-devel@gnu.org; Wed, 26 Apr 2006 12:42:16 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FYn5i-00025u-M6 for emacs-devel@gnu.org; Wed, 26 Apr 2006 12:42:15 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FYn5i-00025r-FY for emacs-devel@gnu.org; Wed, 26 Apr 2006 12:42:14 -0400 Original-Received: from [132.204.24.67] (helo=mercure.iro.umontreal.ca) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FYn8R-0004KB-9I for emacs-devel@gnu.org; Wed, 26 Apr 2006 12:45:03 -0400 Original-Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 481BD2CE9C2; Wed, 26 Apr 2006 12:42:13 -0400 (EDT) Original-Received: from asado.iro.umontreal.ca (asado.iro.umontreal.ca [132.204.24.84]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id 10E91445C; Wed, 26 Apr 2006 12:42:07 -0400 (EDT) Original-Received: by asado.iro.umontreal.ca (Postfix, from userid 20848) id E3CA3714BF; Wed, 26 Apr 2006 12:42:06 -0400 (EDT) Original-To: "Juanma Barranquero" In-Reply-To: (Juanma Barranquero's message of "Wed, 26 Apr 2006 11:38:10 +0200") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:53485 Archived-At: > Unless I'm misundertanding something (likely, as the flu is getting > the better of me), the recent patch to `add-log-iso8601-time-string' > is flawed: > (defun add-log-iso8601-time-string () > (let ((time (format-time-string "%Y-%m-%d" (eq t add-log-time-zone-rule)))) > (if add-log-iso8601-with-time-zone > (concat time " " (add-log-iso8601-time-zone)) > time))) > On one hand, when `add-log-time-zone-rule' is t (possible, according > to its docstring), `format-time-string' receives t as second argument, > which is an error: ELISP> (format-time-string "%Y-%m-%d" t) > *** Eval error *** Wrong type argument: listp, t > On the other hand, `add-log-iso8601-time-zone has a mandatory TIME > argument which is lacking here. Thanks. It should be fixed now, Stefan