From: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Emacs Devel <emacs-devel@gnu.org>
Subject: Re: Error in add-log-iso8601-time-string
Date: Wed, 26 Apr 2006 12:42:06 -0400 [thread overview]
Message-ID: <jwvhd4g9tm9.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <f7ccd24b0604260238y44bc5703qefaf53660670e1b2@mail.gmail.com> (Juanma Barranquero's message of "Wed, 26 Apr 2006 11:38:10 +0200")
> Unless I'm misundertanding something (likely, as the flu is getting
> the better of me), the recent patch to `add-log-iso8601-time-string'
> is flawed:
> (defun add-log-iso8601-time-string ()
> (let ((time (format-time-string "%Y-%m-%d" (eq t add-log-time-zone-rule))))
> (if add-log-iso8601-with-time-zone
> (concat time " " (add-log-iso8601-time-zone))
> time)))
> On one hand, when `add-log-time-zone-rule' is t (possible, according
> to its docstring), `format-time-string' receives t as second argument,
> which is an error:
ELISP> (format-time-string "%Y-%m-%d" t)
> *** Eval error *** Wrong type argument: listp, t
> On the other hand, `add-log-iso8601-time-zone has a mandatory TIME
> argument which is lacking here.
Thanks. It should be fixed now,
Stefan
prev parent reply other threads:[~2006-04-26 16:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-26 9:38 Error in add-log-iso8601-time-string Juanma Barranquero
2006-04-26 16:42 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvhd4g9tm9.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).