unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Juri Linkov <juri@jurta.org>
Cc: rms@gnu.org, emacs-devel@gnu.org
Subject: Re: rfn-eshadow
Date: Thu, 03 Jan 2008 21:51:37 -0500	[thread overview]
Message-ID: <jwvhchu1f6e.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87k5mq60y8.fsf@jurta.org> (Juri Linkov's message of "Thu, 03 Jan 2008 23:42:07 +0200")

> ffap.el mentions FSF as a maintainer, but actually this bug has nothing
> to do with ffap.

On the contrary it has everything to do with ffap.

> The problem is that even if ffap is disabled, when typing an URL in the
> minibuffer, rfn-eshadow.el threats it as a file name, and puts a shadow
> over the `http:' part because it contains double slashes //.

No, it is perfectly right for rfn-eshadow to treat it as a file name,
since that's what rfn-eshadow is all about: to improve file-name entry.
If you want your user to enter something else than a file-name, then
don't set minibuffer-completing-file-name.

> I think the right way to fix this problem is the following patch that
> prevents handling of URLs by file-name-shadow-mode:

No, the right way is for ffap to either not set
minibuffer-completing-file-name (which probably requires more
changes in order to recover the desired completion behavior) or to
explain to rfn-eshadow what kind of file-names are accepted via
a file-name-handler (which can be added only temporarily).

For the record, URL entry works just fine with rfn-eshadow if you enable
url-handler-mode.


        Stefan

  parent reply	other threads:[~2008-01-04  2:51 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-03  9:51 [jidanni@jidanni.org: ffap; prompt turns color misleadingly] Richard Stallman
2008-01-03 21:42 ` rfn-eshadow (Was: [jidanni@jidanni.org: ffap; prompt turns color misleadingly]) Juri Linkov
2008-01-03 22:12   ` rfn-eshadow Michael Albinus
2008-01-03 22:28     ` rfn-eshadow Juri Linkov
2008-01-04  2:51   ` Stefan Monnier [this message]
2008-01-04  9:51     ` rfn-eshadow Juri Linkov
2008-01-04 12:11       ` rfn-eshadow Michael Albinus
2008-01-04 21:52         ` rfn-eshadow Juri Linkov
2008-01-04 22:23           ` rfn-eshadow Michael Albinus
2008-01-05 10:36             ` rfn-eshadow Juri Linkov
2008-01-05 22:34               ` rfn-eshadow Stefan Monnier
2008-01-06 14:08                 ` rfn-eshadow Michael Albinus
2008-01-06 21:54                   ` rfn-eshadow Juri Linkov
2008-01-07  6:57                     ` rfn-eshadow Michael Albinus
2008-01-09  0:59                       ` rfn-eshadow Juri Linkov
2008-01-09  2:17                         ` rfn-eshadow Stefan Monnier
2008-01-09  8:13                           ` rfn-eshadow Michael Albinus
2008-01-05  5:54     ` rfn-eshadow Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvhchu1f6e.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=juri@jurta.org \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).