From: Stefan Monnier <monnier@iro.umontreal.ca>
To: martin rudalics <rudalics@gmx.at>
Cc: Juanma Barranquero <lekktu@gmail.com>,
Emacs Devel <emacs-devel@gnu.org>,
Richard Sharman <rsharman@pobox.com>
Subject: Re: buffer is modified after commit
Date: Wed, 13 Feb 2008 17:01:37 -0500 [thread overview]
Message-ID: <jwvhcgcsekg.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <47B3639E.9070007@gmx.at> (martin rudalics's message of "Wed, 13 Feb 2008 22:39:42 +0100")
>> 3 - buffer-modified-p is incorrectly forcefully set to nil by the
>> special undo entries added in highlight-changes-rotate-faces.
>> That's correct if the buffer was not modified before undoing
>> this command, but is dangerous otherwise (will mark your buffer as
>> unmodified even though you haven't saved the changes).
> Yes, that part is tricky and should be solved by a generic primitive
> rather than my ad-hoc fix. I thought that when the buffer is unmodified
> at the time I do "this command", doing/undoing "this command" and
> setting the modified status to nil should not cause any harm. Can you
> provide a counterexample?
edit
save
rotate
edit
save
undo undo undo...
By the way, I've installed a change on the 22 branch which should fix
the buffer-modified-p problem (and removes this number 3 hack).
Stefan
next prev parent reply other threads:[~2008-02-13 22:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-05 16:31 buffer is modified after commit Juanma Barranquero
2008-02-13 16:04 ` Juanma Barranquero
2008-02-13 18:45 ` martin rudalics
2008-02-13 19:50 ` Stefan Monnier
2008-02-13 21:39 ` martin rudalics
2008-02-13 22:01 ` Stefan Monnier [this message]
2008-02-14 1:56 ` Juanma Barranquero
2008-02-14 7:53 ` martin rudalics
2008-02-14 14:57 ` Stefan Monnier
2008-02-14 22:46 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvhcgcsekg.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=lekktu@gmail.com \
--cc=rsharman@pobox.com \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).