From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: kfogel@red-bean.com, cyd@stupidchicken.com, emacs-devel@gnu.org
Subject: Re: Reviewing changes
Date: Thu, 20 Nov 2008 23:01:00 -0500 [thread overview]
Message-ID: <jwvhc61ohlf.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <u7i6ykv56.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 20 Nov 2008 22:19:33 +0200")
> IMO, if we cannot do it well, it isn't worth doing.
Sounds surprisingly dogmatic.
>> We already have code reviews, just rarely so.
> No, we don't. What we have is random (and very rare) comments, and no
> mechanism to resolve disagreements when they happen.
So you object to naming them "code reviews"? That's OK, let's call them
"random comments", then.
I just can't see how encouraging such random comments can hurt.
Stefan
next prev parent reply other threads:[~2008-11-21 4:01 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1KvFgL-00034A-Gp@cvs.savannah.gnu.org>
2008-11-19 7:50 ` [Emacs-diffs] Changes to emacs/lisp/bookmark.el,v Karl Fogel
2008-11-19 19:17 ` Reviewing changes (was: [Emacs-diffs] Changes to emacs/lisp/bookmark.el, v) Eli Zaretskii
2008-11-19 22:06 ` Reviewing changes Karl Fogel
2008-11-19 22:12 ` Eli Zaretskii
2008-11-19 22:26 ` Thomas Lord
2008-11-20 5:21 ` Karl Fogel
2008-11-20 0:43 ` Stephen J. Turnbull
2008-11-20 6:37 ` Karl Fogel
2008-11-20 8:31 ` Stephen J. Turnbull
2008-11-20 2:13 ` Stefan Monnier
2008-11-20 4:17 ` Eli Zaretskii
2008-11-20 6:22 ` Karl Fogel
2008-11-20 14:30 ` Stefan Monnier
2008-11-20 20:19 ` Eli Zaretskii
2008-11-21 4:01 ` Stefan Monnier [this message]
2008-11-21 4:08 ` mail
2008-11-21 11:28 ` Eli Zaretskii
2008-11-21 14:32 ` Stefan Monnier
2008-11-21 15:14 ` Eli Zaretskii
2008-11-21 19:14 ` Stefan Monnier
2008-11-20 10:25 ` Yavor Doganov
2008-11-21 4:05 ` Stefan Monnier
2008-11-20 5:39 ` [Emacs-diffs] Changes to emacs/lisp/bookmark.el,v Miles Bader
2008-11-20 9:37 ` Andreas Schwab
2008-11-20 10:09 ` Miles Bader
2008-11-20 20:22 ` Eli Zaretskii
2008-11-20 20:32 ` Juanma Barranquero
2008-11-20 20:44 ` Eli Zaretskii
2008-11-21 5:38 ` Karl Fogel
2008-11-21 11:43 ` Eli Zaretskii
2008-11-23 19:11 ` martin rudalics
2008-11-24 20:20 ` Eli Zaretskii
2008-11-25 15:23 ` Karl Fogel
2008-11-25 16:25 ` martin rudalics
2008-11-25 16:25 ` martin rudalics
2008-11-25 21:07 ` Eli Zaretskii
2008-11-26 2:17 ` Stephen J. Turnbull
2008-11-27 13:41 ` martin rudalics
2008-11-27 16:35 ` Stefan Monnier
2008-11-25 21:44 ` Stefan Monnier
2008-11-21 19:29 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvhc61ohlf.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=cyd@stupidchicken.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=kfogel@red-bean.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).