From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [patch] convert footnote.el to use define-minor-mode Date: Fri, 12 Dec 2008 22:13:46 -0500 Message-ID: References: <86d4fx82jd.fsf@nirvana.pusto.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1229138044 5353 80.91.229.12 (13 Dec 2008 03:14:04 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 13 Dec 2008 03:14:04 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eduard Wiebe Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Dec 13 04:15:08 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LBKyA-0008He-RH for ged-emacs-devel@m.gmane.org; Sat, 13 Dec 2008 04:15:07 +0100 Original-Received: from localhost ([127.0.0.1]:49268 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LBKwz-0001Pr-1F for ged-emacs-devel@m.gmane.org; Fri, 12 Dec 2008 22:13:53 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LBKwv-0001PU-45 for emacs-devel@gnu.org; Fri, 12 Dec 2008 22:13:49 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LBKwt-0001O9-Jn for emacs-devel@gnu.org; Fri, 12 Dec 2008 22:13:48 -0500 Original-Received: from [199.232.76.173] (port=52646 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LBKwt-0001O2-HA for emacs-devel@gnu.org; Fri, 12 Dec 2008 22:13:47 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:8996) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LBKwt-0004op-AX for emacs-devel@gnu.org; Fri, 12 Dec 2008 22:13:47 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApsEAMK3QklMConz/2dsb2JhbACBbM1Dgn2BLw X-IronPort-AV: E=Sophos;i="4.36,215,1228107600"; d="scan'208";a="30998617" Original-Received: from 76-10-137-243.dsl.teksavvy.com (HELO pastel.home) ([76.10.137.243]) by ironport2-out.teksavvy.com with ESMTP; 12 Dec 2008 22:13:46 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id A22A286F6; Fri, 12 Dec 2008 22:13:46 -0500 (EST) In-Reply-To: <86d4fx82jd.fsf@nirvana.pusto.de> (Eduard Wiebe's message of "Fri, 12 Dec 2008 23:13:58 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:106864 Archived-At: > 2008-12-12 Eduard Wiebe > * mail/footnote.el (footnote-mode): Use define-minor-mode > (footnote-prefix): Use defcustom Looks very good, thank you. Except you've renamed footnote-prefix to footnote-mode-prefix, which doesn't seem to be worth the trouble (of and ChangeLog text should end with "."). Stefan