unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Juri Linkov <juri@jurta.org>
Cc: emacs-devel@gnu.org
Subject: Re: Virtual Info files and nodes
Date: Mon, 29 Jun 2009 10:42:28 +0200	[thread overview]
Message-ID: <jwvhbxz4esu.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87prcnhn4i.fsf@mail.jurta.org> (Juri Linkov's message of "Mon, 29 Jun 2009 03:48:21 +0300")

>> - Why regexps for filenames?
> This is a forethought for possible future cases.  But maybe only strings
> should be allowed now, and regexps can be added only when necessary.

Nah, you might as well stick to regexps indeed.  I'm not sure what
I was thinking.

>> - Why check (stringp filename) in Info-virtual-file?  Isn't it an
>> error to call it with something else than a string.
> Really only nil can be expected now,

Can it?  In which circumstance?

> but `stringp' is a precaution
> against t (the current internal value for "dir" ) and former symbol
> values `apropos', `toc' (maybe some external packages still use them).

Please mention it in a comment.

>> - Why have separate Info-virtual-file and Info-virtual-node functions?
>> (the latter is only called (once) from Info-virtual-fun, and the former
>> is called once from Info-virtual-fun and another time where it seems
>> that Info-virtual-fun could be used in its stead).

> Info-virtual-fun expects an argument `op' for an operation type,
> but these places call (Info-virtual-file file) with only a file name
> argument to check whether a file name is virtual (if its name is defined
> in a list of definitions of virtual Info files).

Why not provide a dummy `find-file' value for the `op'?
And wrap this in an Info-virtual-file-p function?


        Stefan




  reply	other threads:[~2009-06-29  8:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-28 21:28 Virtual Info files and nodes Juri Linkov
2009-06-29  0:14 ` Stefan Monnier
2009-06-29  0:48   ` Juri Linkov
2009-06-29  8:42     ` Stefan Monnier [this message]
2009-06-29 23:55       ` Juri Linkov
     [not found]         ` <jwvr5x11odl.fsf-monnier+emacs@gnu.org>
2009-07-01  0:01           ` Juri Linkov
2009-07-01 15:02             ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvhbxz4esu.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=juri@jurta.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).