Docstring of rename-buffer

Docstring of rename-buffer

[Antoine Levitt]

[-- Attachment #1: Type: text/plain, Size: 196 bytes --]

rename-buffer currently prompts "Rename buffer (to new name)", which
feels a bit clumsy (the parenthesis is here to dispel an ambiguity that
could be avoided in the first place). How about this?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: docstring-rename-buffer.diff --]
[-- Type: text/x-diff, Size: 867 bytes --]

=== modified file 'src/ChangeLog'
--- src/ChangeLog	2011-08-24 11:49:54 +0000
+++ src/ChangeLog	2011-08-24 12:41:30 +0000
@@ -1,3 +1,7 @@
+2011-08-24  Antoine Levitt  <antoine.levitt@gmail.com>
+
+	* buffer.c (Frename_buffer): Clarify prompt.
+
 2011-08-24  Eli Zaretskii  <eliz@gnu.org>
 
 	* xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte

=== modified file 'src/buffer.c'
--- src/buffer.c	2011-07-28 17:46:21 +0000
+++ src/buffer.c	2011-08-24 12:30:18 +0000
@@ -1233,7 +1233,7 @@
 }
 \f
 DEFUN ("rename-buffer", Frename_buffer, Srename_buffer, 1, 2,
-       "(list (read-string \"Rename buffer (to new name): \" \
+       "(list (read-string (format \"Rename %s to: \" (current-buffer)) \
 	      nil 'buffer-name-history (buffer-name (current-buffer))) \
 	      current-prefix-arg)",
        doc: /* Change current buffer's name to NEWNAME (a string).

Re: Docstring of rename-buffer

[Stefan Monnier]

>  DEFUN ("rename-buffer", Frename_buffer, Srename_buffer, 1, 2,
> -       "(list (read-string \"Rename buffer (to new name): \" \
> +       "(list (read-string (format \"Rename %s to: \" (current-buffer)) \
>  	      nil 'buffer-name-history (buffer-name (current-buffer))) \
>  	      current-prefix-arg)",
>         doc: /* Change current buffer's name to NEWNAME (a string).

Sounds good, please apply,


        Stefan

Re: Docstring of rename-buffer

[Antoine Levitt]

24/08/11 17:05, Stefan Monnier
>>  DEFUN ("rename-buffer", Frename_buffer, Srename_buffer, 1, 2,
>> -       "(list (read-string \"Rename buffer (to new name): \" \
>> +       "(list (read-string (format \"Rename %s to: \" (current-buffer)) \
>>  	      nil 'buffer-name-history (buffer-name (current-buffer))) \
>>  	      current-prefix-arg)",
>>         doc: /* Change current buffer's name to NEWNAME (a string).
>
> Sounds good, please apply,
>
>
>         Stefan

Are you talking to me? I can't, I haven't got commit access, I was
posting the patch so that someone could commit it.

Re: Docstring of rename-buffer

[Chong Yidong]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>>  DEFUN ("rename-buffer", Frename_buffer, Srename_buffer, 1, 2,
>> -       "(list (read-string \"Rename buffer (to new name): \" \
>> +       "(list (read-string (format \"Rename %s to: \" (current-buffer)) \
>>  	      nil 'buffer-name-history (buffer-name (current-buffer))) \
>>  	      current-prefix-arg)",
>>         doc: /* Change current buffer's name to NEWNAME (a string).
>
> Sounds good, please apply,

For consistency with other similar commands, I think it's better to ask
"Rename buffer to: ", omitting the old buffer name.