From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Lars Magne Ingebrigtsen <larsi@gnus.org>
Cc: 2553@debbugs.gnu.org, Chong Yidong <cyd@stupidchicken.com>,
emacs-devel@gnu.org, David Reitter <david.reitter@gmail.com>
Subject: Re: *vc-diff* buffers are read-only, but M-k works
Date: Mon, 12 Sep 2011 21:26:03 -0400 [thread overview]
Message-ID: <jwvhb4hp72h.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <m3bouqhhvn.fsf@stories.gnus.org> (Lars Magne Ingebrigtsen's message of "Sun, 11 Sep 2011 23:46:36 +0200")
>> The purpose of making the vc-diff buffer read-only (2007-11-10 change to
>> vc.el) was so that people can use the read-only diff-mode bindings like
>> "k" and "p". However, it's counter-intuitive that undo does not work.
>> Probably the easiest fix is to define a diff-undo command that lifts the
>> read-only restriction temporarily. Any thoughts?
> Perhaps a more general solution would be possible here. I think there
> probably are other "mostly-read-only" modes where you have one or two
> special commands that alter the buffer, anyway. Like with `M-k'.
> Perhaps there could be a buffer-local variable like
> `undo-read-only-buffer' that if set, would allow `undo' to work in these
> cases.
Or we could record in the buffer-undo-list the fact the the modification
was done with inhibit-read-only bound to non-nil, and bind it similarly
during the undo.
Stefan
next prev parent reply other threads:[~2011-09-13 1:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-04 15:41 *vc-diff* buffers are read-only, but M-k works Chong Yidong
2009-03-04 15:54 ` Juanma Barranquero
2011-09-11 21:46 ` Lars Magne Ingebrigtsen
2011-09-13 1:26 ` Stefan Monnier [this message]
2011-10-06 21:59 ` bug#2553: " Lars Magne Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvhb4hp72h.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=2553@debbugs.gnu.org \
--cc=cyd@stupidchicken.com \
--cc=david.reitter@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).