unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* split-window-{right, below} not interchangeable with split-window-sensibly
@ 2012-07-18  6:52 Tassilo Horn
  2012-07-18  8:22 ` Stefan Monnier
  0 siblings, 1 reply; 5+ messages in thread
From: Tassilo Horn @ 2012-07-18  6:52 UTC (permalink / raw)
  To: emacs-devel

Hello,

I really like sensible window splitting, and basically I want to use it
almost everywhere.  (That's what split-window-preferred-function is for
which works just fine.)

However, there are modes like ediff that have their own
foo-split-window-fn defcustom.  There you can use both
split-window-{right,below}, but split-window-sensibly doesn't
necessarily work, because the former functions have an optional SIZE arg
while the latter has a mandatory WINDOW arg.

For example, ediff just does

    (funcall ediff-split-window-function)

and that clearly errors if its set to split-window-sensibly.
Internally, ediff somehow ignores the error and you end up with only one
buffer.

Wouldn't it make sense to have the same signatures for
split-window-sensibly and the other two functions so that they were
interchangeable?

Well, the SIZE arg is not too meaningful for split-window-sensibly as it
would mean either SIZE cols or lines...  So maybe just making its WINDOW
arg optional would suffice for almost all use-cases.

Bye,
Tassilo



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2012-07-23 10:52 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-18  6:52 split-window-{right, below} not interchangeable with split-window-sensibly Tassilo Horn
2012-07-18  8:22 ` Stefan Monnier
2012-07-18 10:16   ` Tassilo Horn
2012-07-18 10:44     ` Tassilo Horn
2012-07-23 10:52       ` Nix

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).