From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: CEDET non-regression bug fixes Date: Tue, 13 Nov 2012 20:17:10 -0500 Message-ID: References: <87k3tprzss.fsf@engster.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1352855839 24517 80.91.229.3 (14 Nov 2012 01:17:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 14 Nov 2012 01:17:19 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 14 02:17:29 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TYRbd-0004It-Id for ged-emacs-devel@m.gmane.org; Wed, 14 Nov 2012 02:17:29 +0100 Original-Received: from localhost ([::1]:57103 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TYRbT-0002zZ-T2 for ged-emacs-devel@m.gmane.org; Tue, 13 Nov 2012 20:17:19 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:40937) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TYRbP-0002zS-3I for emacs-devel@gnu.org; Tue, 13 Nov 2012 20:17:18 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TYRbM-0001Or-0A for emacs-devel@gnu.org; Tue, 13 Nov 2012 20:17:14 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:23815) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TYRbL-0001OW-Rv for emacs-devel@gnu.org; Tue, 13 Nov 2012 20:17:11 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ai0FAG6Zu09sr+ZY/2dsb2JhbABEsEiDSYEIghYBBVYzCzQSFBgNiEW6CY0mgx4DiEKacYFYgwc X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="207568482" Original-Received: from 108-175-230-88.dsl.teksavvy.com (HELO pastel.home) ([108.175.230.88]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 13 Nov 2012 20:17:11 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id C9133590D3; Tue, 13 Nov 2012 20:17:10 -0500 (EST) In-Reply-To: <87k3tprzss.fsf@engster.org> (David Engster's message of "Tue, 13 Nov 2012 21:52:19 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.182 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:154858 Archived-At: > --- lisp/cedet/semantic/fw.el 2012-10-07 12:07:12 +0000 > +++ lisp/cedet/semantic/fw.el 2012-10-27 19:55:04 +0000 > @@ -421,14 +421,7 @@ > ;; Don't prompt to insert a template if we visit an empty file > (auto-insert nil) > ;; We don't want emacs to query about unsafe local variables > - (enable-local-variables > - (if (featurep 'xemacs) > - ;; XEmacs only has nil as an option? > - nil > - ;; Emacs 23 has the spiffy :safe option, nil otherwise. > - (if (>= emacs-major-version 22) > - nil > - :safe))) > + (enable-local-variables :safe) > ;; ... or eval variables > (enable-local-eval nil) > ) Fine. > === modified file 'lisp/cedet/semantic/symref/list.el' > --- lisp/cedet/semantic/symref/list.el 2012-09-02 18:37:45 +0000 > +++ lisp/cedet/semantic/symref/list.el 2012-11-04 21:03:27 +0000 > @@ -69,7 +69,7 @@ > references are organized by file and the name of the function > they are used in. > Display the references in `semantic-symref-results-mode'." > - (interactive (list (semantic-tag-name (semantic-complete-read-tag-buffer-deep > + (interactive (list (semantic-tag-name (semantic-complete-read-tag-project > "Symrefs for: ")))) > (semantic-fetch-tags) > (let ((res nil) >From what you say, it's OK. > === modified file 'lisp/cedet/semantic/complete.el' > --- lisp/cedet/semantic/complete.el 2012-10-12 19:56:34 +0000 > +++ lisp/cedet/semantic/complete.el 2012-11-04 21:06:33 +0000 > @@ -1340,7 +1343,10 @@ > (defmethod semantic-displayor-scroll-request ((obj semantic-displayor-abstract)) > "A request to for the displayor to scroll the completion list (if needed)." > - (scroll-other-window)) > + (with-selected-window (get-buffer-window "*Completions*") > + (if (posn-at-point (point-max)) > + (goto-char (point-min)) > + (scroll-up)))) This will signal an error when *Completions* is not displayed anywhere. > - (buff (get-file-buffer file)) > + (buff (find-buffer-visiting file)) We need to do something to avoid those problems. AFAIK there's no reason to ever prefer get-file-buffer over find-buffer-visiting, so maybe we should simply get rid of get-file-buffer and make it an alias of find-buffer-visiting. Stefan