From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Redundant (harmful) duplication of run-hooks in define-globalized-minor-mode [patch] Date: Mon, 14 Jan 2013 21:12:15 -0500 Message-ID: References: <20130113192854.GA4853@acm.acm> <20130114163003.GC3274@acm.acm> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1358215948 27311 80.91.229.3 (15 Jan 2013 02:12:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 15 Jan 2013 02:12:28 +0000 (UTC) Cc: emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jan 15 03:12:46 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Tuw16-00085z-Oz for ged-emacs-devel@m.gmane.org; Tue, 15 Jan 2013 03:12:44 +0100 Original-Received: from localhost ([::1]:44247 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tuw0q-0000Pb-68 for ged-emacs-devel@m.gmane.org; Mon, 14 Jan 2013 21:12:28 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:58833) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tuw0n-0000PK-98 for emacs-devel@gnu.org; Mon, 14 Jan 2013 21:12:26 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tuw0j-0006HG-6U for emacs-devel@gnu.org; Mon, 14 Jan 2013 21:12:25 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:34150) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tuw0j-0006H9-2s for emacs-devel@gnu.org; Mon, 14 Jan 2013 21:12:21 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AtkGAG6Zu09FpZpV/2dsb2JhbABEgXuyFoEIghYBBVYjEAsOJhIUGA0kiCG6CZBEA4hCmnGBWIMH X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="212564641" Original-Received: from 69-165-154-85.dsl.teksavvy.com (HELO pastel.home) ([69.165.154.85]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 14 Jan 2013 21:12:18 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 921AE5927F; Mon, 14 Jan 2013 21:12:16 -0500 (EST) In-Reply-To: <20130114163003.GC3274@acm.acm> (Alan Mackenzie's message of "Mon, 14 Jan 2013 16:30:03 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.182 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:156364 Archived-At: > ! (add-hook 'after-change-major-mode-hook > ! ',MODE-enable-in-buffers) > ! (add-hook 'change-major-mode-after-body-hook > ',MODE-enable-in-buffers) > (add-hook 'find-file-hook ',MODE-check-buffers) > (add-hook 'change-major-mode-hook ',MODE-cmhh)) > --- 399,407 ---- > ;; Setup hook to handle future mode changes and new buffers. > (if ,global-mode > (progn > ! (add-hook ',(if call-before-hook > ! 'change-major-mode-after-body-hook > ! 'after-change-major-mode-hook) I think we first need to understand why we currently use both. Also, the MODE-enable-in-buffers function should enable the mode only once, normally, even if called via both hooks. So if you see a problem, maybe it's because (eq ,MODE-major-mode major-mode) is not true the second time around, i.e. because `major-mode' has changed between the two hooks. Is that the case? If so, why? Stefan