From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Any exceptions for the 15-line rule? Date: Sat, 27 Apr 2013 00:41:06 -0400 Message-ID: References: <87d2tgu0ad.fsf@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1367037672 23123 80.91.229.3 (27 Apr 2013 04:41:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 27 Apr 2013 04:41:12 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Apr 27 06:41:16 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UVwwi-00067f-5E for ged-emacs-devel@m.gmane.org; Sat, 27 Apr 2013 06:41:12 +0200 Original-Received: from localhost ([::1]:54252 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVwwh-0005T5-Nu for ged-emacs-devel@m.gmane.org; Sat, 27 Apr 2013 00:41:11 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:45002) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVwwe-0005S7-Sg for emacs-devel@gnu.org; Sat, 27 Apr 2013 00:41:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UVwwe-0005d7-0z for emacs-devel@gnu.org; Sat, 27 Apr 2013 00:41:08 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:47172) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVwwd-0005cz-Te for emacs-devel@gnu.org; Sat, 27 Apr 2013 00:41:07 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFFFpYYW/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLDiYSFBgNJIgeBrhviD6NGoNwA6R6gV6DE4FL X-IPAS-Result: Av4EABK/CFFFpYYW/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLDiYSFBgNJIgeBrhviD6NGoNwA6R6gV6DE4FL X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="8627853" Original-Received: from 69-165-134-22.dsl.teksavvy.com (HELO pastel.home) ([69.165.134.22]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 27 Apr 2013 00:41:02 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 518FD67973; Sat, 27 Apr 2013 00:41:06 -0400 (EDT) In-Reply-To: <87d2tgu0ad.fsf@yandex.ru> (Dmitry Gutov's message of "Sat, 27 Apr 2013 07:20:42 +0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.182 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:159177 Archived-At: > The latter is licensed under GPLv3+, but I'm pretty sure the author > (brianjcj AT gmail, not sure what's his full name) has not signed the > CA. And I'm not wild about the idea of waiting several months to add the > feature (that is, if the author even agrees to sign the CA). The change includes - (with-temp-buffer + (buf (get-buffer-create "*clang-output*")) + (with-current-buffer buf (erase-buffer)) + (with-current-buffer buf Which seems like it's making the code worse rather than better. If you undo this undesirable part of the patch, it'll be closer to the acceptable limit. For company-clang--lang-option, I'd be tempted to use (defun company-clang--lang-option () (if (eq major-mode 'objc-mode) (if (string= "m" (file-name-extension buffer-file-name)) "objective-c" "objective-c++") (substring (symbol-name major-mode) 0 -5))) With such cleanups, the patch seems acceptable as a "tiny change". But please do ask for the CA as well (so the use of "tiny change" is mostly a way to avoid having to wait for the CA to go through). Stefan