Re: [Emacs-diffs] trunk r115545: Cleanup cfengine3-mode so complete-symbol works again.

Re: [Emacs-diffs] trunk r115545: Cleanup cfengine3-mode so complete-symbol works again.

[Stefan Monnier]

>  (defun cfengine3-completion-function ()
>    "Return completions for function name around or before point."
>    (cfengine3-make-syntax-cache)
> -  (let* ((bounds (cfengine3--current-word t))
> +  (let* ((bounds (save-excursion
> +                   (let ((p (point)))
> +                     (skip-syntax-backward "w_" (point-at-bol))
> +                     (list (point) p))))
>           (syntax (cfengine3-make-syntax-cache))
>           (flist (assq 'functions syntax)))

BTW, it would be better for cfengine3-completion-function not to call
cfengine3-make-syntax-cache which can cause all kinds of processing
to happen.  Instead it should return a completion-table-dynamic or
something like that, such that cfengine3-make-syntax-cache is only
called if/when the completion-table is actually used.


        Stefan

Re: [Emacs-diffs] trunk r115545: Cleanup cfengine3-mode so complete-symbol works again.

[Ted Zlatanov]

On Mon, 16 Dec 2013 21:25:14 -0500 Stefan Monnier <monnier@IRO.UMontreal.CA> wrote: 

>> (defun cfengine3-completion-function ()
>> "Return completions for function name around or before point."
>> (cfengine3-make-syntax-cache)
>> -  (let* ((bounds (cfengine3--current-word t))
>> +  (let* ((bounds (save-excursion
>> +                   (let ((p (point)))
>> +                     (skip-syntax-backward "w_" (point-at-bol))
>> +                     (list (point) p))))
>> (syntax (cfengine3-make-syntax-cache))
>> (flist (assq 'functions syntax)))

SM> BTW, it would be better for cfengine3-completion-function not to call
SM> cfengine3-make-syntax-cache which can cause all kinds of processing
SM> to happen.  Instead it should return a completion-table-dynamic or
SM> something like that, such that cfengine3-make-syntax-cache is only
SM> called if/when the completion-table is actually used.

I'm not sure I agree.  `cfengine3-make-syntax-cache' is only expensive
the first time, unless there are problems running the
`cfengine-cf-promises' binary (should I attempt just once? but then it's
not idempotent...).  After that, it's just a couple of built-in
functions to retrieve the cache from memory, if+cddr+assoc.

Or is the name a problem because it implies the cache is remade every time?

Ted