From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Subject: Re: Feature freeze
Date: Mon, 06 Jan 2014 19:19:47 -0500 [thread overview]
Message-ID: <jwvha9gprxj.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87eh4kzss5.fsf@engster.org> (David Engster's message of "Mon, 06 Jan 2014 22:47:54 +0100")
> Is it OK to install, or will it have to wait?
Looks OK. Please install, tho see nitpicks below.
> + ;; Describe all the slots in this class
Please punctuate the comments (IIUC you didn't actually change this
comment, but while you're there, you might as well do it ;-).
> +(defvar help-fns-describe-function-functions nil
> + "List of functions to run in help buffer in `describe-function'.
> +Those functions will be run after the header line and argument
> +list was inserted, and before the documentation will be inserted.
> +The functions will receive the function name as argument.")
> +
> ;; Functions
>
> ;;;###autoload
> @@ -653,7 +659,7 @@
> (help-fns--compiler-macro function)
> (help-fns--parent-mode function)
> (help-fns--obsolete function)
> -
> + (run-hook-with-args 'help-fns-describe-function-functions function)
Looks good, but please move help-fns--compiler-macro,
help-fns--parent-mode, help-fns--obsolete to
help-fns-describe-function-functions while you're there.
Stefan
next prev parent reply other threads:[~2014-01-07 0:19 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-24 3:48 Feature freeze Stefan Monnier
2013-12-24 4:49 ` Dmitry Gutov
2013-12-24 6:08 ` Leo Liu
2013-12-24 7:37 ` Bozhidar Batsov
2013-12-24 14:02 ` Stefan Monnier
2013-12-24 14:50 ` João Távora
2013-12-24 15:16 ` Stefan Monnier
2013-12-26 22:16 ` João Távora
2013-12-26 23:46 ` João Távora
2013-12-27 7:54 ` Eli Zaretskii
2013-12-27 3:48 ` Dmitry Gutov
2013-12-24 14:05 ` David Engster
2013-12-24 15:18 ` Stefan Monnier
2014-01-06 21:47 ` David Engster
2014-01-07 0:19 ` Stefan Monnier [this message]
2014-01-07 21:30 ` David Engster
2014-01-08 3:20 ` Stefan Monnier
2014-01-08 22:04 ` David Engster
2014-01-08 22:31 ` Glenn Morris
2014-01-08 22:37 ` Glenn Morris
2014-01-09 6:29 ` Eli Zaretskii
2014-01-09 7:21 ` David Engster
2014-01-09 17:05 ` Glenn Morris
2014-01-09 21:21 ` David Engster
2014-01-11 20:41 ` Nix
2013-12-26 13:50 ` Stefan Monnier
2013-12-27 16:26 ` Michael Albinus
2013-12-27 21:37 ` Stefan Monnier
2013-12-28 12:34 ` Michael Albinus
-- strict thread matches above, loose matches on Subject: below --
2015-09-21 19:39 Stefan Monnier
2015-09-21 21:19 ` Kaushal Modi
2015-09-21 21:30 ` John Yates
2015-09-21 21:39 ` Rasmus
2015-09-22 0:52 ` Xue Fuqiao
2015-09-22 6:35 ` Eli Zaretskii
2015-09-22 6:39 ` martin rudalics
2015-09-22 8:19 ` Zack Piper
2015-09-22 8:53 ` Aurélien Aptel
2015-09-22 9:14 ` Artur Malabarba
2015-09-22 11:41 ` Tassilo Horn
2015-09-22 9:14 ` Eric Abrahamsen
2015-09-22 10:37 ` Alan Mackenzie
2015-09-22 11:50 ` Oleh Krehel
2015-09-22 13:03 ` Dmitry Gutov
2015-09-22 20:18 ` Paul Eggert
2015-09-30 7:31 ` Bastien
2015-09-28 20:40 ` Nicolas Petton
2015-09-29 14:25 ` Richard Stallman
2015-10-01 1:08 ` Leo Liu
2015-10-02 2:21 ` Daniel Colascione
2015-10-02 3:47 ` John Wiegley
2015-10-13 20:49 ` joakim
2013-12-15 13:35 Stefan Monnier
2013-12-16 14:02 ` Jambunathan K
2013-12-16 15:14 ` Stefan Monnier
2013-12-16 16:32 ` Jambunathan K
2013-12-16 17:14 ` Glenn Morris
2013-12-16 18:49 ` Stefan Monnier
2013-12-16 19:34 ` Eli Zaretskii
2013-12-17 1:59 ` Stefan Monnier
2013-12-18 7:28 ` Jambunathan K
2013-12-16 20:35 ` Michael Albinus
2013-12-16 20:49 ` Jambunathan K
2013-12-16 21:38 ` Michael Albinus
2013-12-16 21:53 ` Jambunathan K
2013-12-16 21:58 ` Jambunathan K
2013-12-17 6:52 ` Michael Albinus
2013-12-17 9:51 ` Jambunathan K
2013-12-17 12:26 ` Juanma Barranquero
2013-12-18 5:36 ` Jambunathan K
2013-12-18 6:13 ` Jay Belanger
2013-12-18 6:18 ` Jambunathan K
2013-12-18 6:52 ` Jay Belanger
2013-12-18 6:57 ` Jambunathan K
2013-12-18 7:08 ` Jay Belanger
2013-12-18 7:11 ` Jambunathan K
2013-12-18 7:07 ` Glenn Morris
2013-12-18 7:32 ` Jambunathan K
2013-12-18 12:25 ` Stefan Monnier
2013-12-18 12:48 ` Bozhidar Batsov
[not found] <4E17F5F8.7060200@cs.ucla.edu>
[not found] ` <4E1936D7.4030302@cs.ucla.edu>
[not found] ` <CAAeL0SSAmYPugdLEvch5-J9T17BWf9W+xgXdFxvpC_qWWq-DLg@mail.gmail.com>
[not found] ` <jwvmxglrnmj.fsf-monnier+emacs@gnu.org>
[not found] ` <4E1B3224.5050804@cs.ucla.edu>
[not found] ` <jwvpqlg9kjo.fsf-monnier+emacs@gnu.org>
[not found] ` <CAAeL0SREPJvq7Hq5xfMisSPY2dr4V0hMRiLxVfjOpq6kWA_6Lw@mail.gmail.com>
2011-07-13 4:03 ` Stefan Monnier
2008-07-31 4:55 Chong Yidong
2008-08-01 1:42 ` Kenichi Handa
2006-08-02 22:45 Feature Freeze Nick Roberts
2006-08-03 0:40 ` Chong Yidong
2006-08-03 2:47 ` Nick Roberts
2004-10-26 18:55 finger-pointer curser as default for mouse-face text Drew Adams
2004-10-26 21:54 ` Kim F. Storm
2004-10-27 2:15 ` Luc Teirlinck
2004-10-27 12:52 ` Kim F. Storm
2004-10-27 13:16 ` David Kastrup
2004-10-27 14:51 ` feature freeze (was: finger-pointer curser as default for mouse-face text) Reiner Steib
2004-10-27 15:15 ` feature freeze David Kastrup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvha9gprxj.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).