From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] trunk r117846: Add macros to allocate temporary Lisp objects with alloca.
Date: Tue, 09 Sep 2014 09:13:38 -0400 [thread overview]
Message-ID: <jwvha0hndrq.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <E1XRCNv-0007Z7-Ic@vcs.savannah.gnu.org> (Dmitry Antipov's message of "Tue, 09 Sep 2014 03:46:27 +0000")
> --- a/src/lisp.h 2014-09-07 07:04:01 +0000
> +++ b/src/lisp.h 2014-09-09 03:44:06 +0000
> @@ -298,6 +298,13 @@
> # endif
> #endif
>
> +/* Stolen from gnulib. */
> +#if (__GNUC__ || __HP_cc || __HP_aCC || __IBMC__ \
> + || __IBMCPP__ || __ICC || 0x5110 <= __SUNPRO_C)
> +#define GCALIGNED __attribute__ ((aligned (GCALIGNMENT)))
> +#else
> +#define GCALIGNED /* empty */
> +#endif
Any reason you don't use the `alignas' we already use/check just above?
> +#if (__GNUC__ || __HP_cc || __HP_aCC || __IBMC__ \
> + || __IBMCPP__ || __ICC || 0x5110 <= __SUNPRO_C)
Yuck! Why not check USE_LSB_TAG?
- USE_LSB_TAG is only set when we have alignas defined.
- When USE_LSB_TAG is not set, you don't need special alignment.
Stefan
next parent reply other threads:[~2014-09-09 13:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1XRCNv-0007Z7-Ic@vcs.savannah.gnu.org>
2014-09-09 13:13 ` Stefan Monnier [this message]
2014-09-09 14:16 ` [Emacs-diffs] trunk r117846: Add macros to allocate temporary Lisp objects with alloca Dmitry Antipov
2014-09-09 15:10 ` Paul Eggert
2014-09-10 6:43 ` Paul Eggert
2014-09-10 8:20 ` Dmitry Antipov
2014-09-10 15:28 ` Paul Eggert
2014-09-09 17:55 ` Stefan Monnier
2014-09-09 18:37 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvha0hndrq.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=dmantipov@yandex.ru \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).