From: Stefan Monnier <monnier@iro.umontreal.ca>
To: phillip.lord@newcastle.ac.uk (Phillip Lord)
Cc: emacs-devel@gnu.org
Subject: Re: [Request for Mentor] subst-char-in-region
Date: Fri, 12 Dec 2014 09:35:16 -0500 [thread overview]
Message-ID: <jwvh9x1vt1r.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87r3w5jdow.fsf@newcastle.ac.uk> (Phillip Lord's message of "Fri, 12 Dec 2014 11:43:43 +0000")
> ooo
> bbb
> Changing ooo to xxx reports the following from Emacs
> before(1,8)
> after(1,4,3)
That looks correct to me.
> origin/fix/subst-char-in-region
> (hopefully adding a new branch is okay for this, obviously it can be
> deleted later). After adding this fix I get...
Please use "scratch/<foo>" rather than "fix/<foo>".
> before(1,8)
> after(1,8,8)
This wouldn't be wrong, but would be less precise.
> Assuming others agree with me that this behaviour is wrong, I would like
> to fix the problem, but would welcome some help and code review.
Assuming a close&direct correct correspondence between
before-change-functions and after-change-functions is just a bad idea.
Does you code *really* need that?
Stefan
next prev parent reply other threads:[~2014-12-12 14:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-12 11:43 [Request for Mentor] subst-char-in-region Phillip Lord
2014-12-12 14:35 ` Stefan Monnier [this message]
2014-12-12 15:05 ` Phillip Lord
2014-12-12 16:17 ` Stefan Monnier
2014-12-15 12:15 ` Phillip Lord
2014-12-15 14:29 ` Stefan Monnier
2014-12-16 11:30 ` Phillip Lord
2014-12-16 14:07 ` Stefan Monnier
2014-12-16 16:05 ` Phillip Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvh9x1vt1r.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=phillip.lord@newcastle.ac.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).