From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 3/3] lisp/mpc.el (mpc--proc-connect): use file-name-absolute-p Date: Mon, 07 Sep 2015 21:16:16 -0400 Message-ID: References: <1441668682-21988-1-git-send-email-mvoteiza@udel.edu> <1441668682-21988-3-git-send-email-mvoteiza@udel.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1441675008 11298 80.91.229.3 (8 Sep 2015 01:16:48 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 8 Sep 2015 01:16:48 +0000 (UTC) Cc: emacs-devel@gnu.org To: Mark Oteiza Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Sep 08 03:16:39 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZZ7WW-0002ve-G3 for ged-emacs-devel@m.gmane.org; Tue, 08 Sep 2015 03:16:36 +0200 Original-Received: from localhost ([::1]:59448 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZ7WW-00009G-6T for ged-emacs-devel@m.gmane.org; Mon, 07 Sep 2015 21:16:36 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53854) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZ7WJ-000093-4K for emacs-devel@gnu.org; Mon, 07 Sep 2015 21:16:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZZ7WE-00080f-2h for emacs-devel@gnu.org; Mon, 07 Sep 2015 21:16:23 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:11532) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZ7WD-00080b-Ul for emacs-devel@gnu.org; Mon, 07 Sep 2015 21:16:18 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0AsEwA731xV/5Wg+M5cDoMChAKFVbs3CYdLBAICgTw5FAEBAQEBAQGBCkEFg10BAQRWIxALDiYSFBgNJIg/zyMBAQEHAgEfizqFBQeELQWLRKd7gUUjYYJZWiKCeAEBAQ X-IPAS-Result: A0AsEwA731xV/5Wg+M5cDoMChAKFVbs3CYdLBAICgTw5FAEBAQEBAQGBCkEFg10BAQRWIxALDiYSFBgNJIg/zyMBAQEHAgEfizqFBQeELQWLRKd7gUUjYYJZWiKCeAEBAQ X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="162849877" Original-Received: from 206-248-160-149.dsl.teksavvy.com (HELO pastel.home) ([206.248.160.149]) by ironport2-out.teksavvy.com with ESMTP; 07 Sep 2015 21:16:18 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 2F2D05F8F7; Mon, 7 Sep 2015 21:16:16 -0400 (EDT) In-Reply-To: <1441668682-21988-3-git-send-email-mvoteiza@udel.edu> (Mark Oteiza's message of "Mon, 7 Sep 2015 19:31:22 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:189690 Archived-At: > - (when (string-prefix-p "/" host) ;FIXME: Use file-name-absolute-p? > + (when (file-name-absolute-p host) > + ;; Expand file name because `file-name-absolute-p' > + ;; considers paths beginning with "~" as absolute > + (setq host (expand-file-name host)) So do you think using file-name-absolute-p is better? I left it as a FIXME, because I simply didn't know the answer. If you set $MPD_HOST to "~/.mpdsocket" do other MPD clients handle it correctly? What about under w32? Stefan