From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Mark Oteiza <mvoteiza@udel.edu>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH 3/3] lisp/mpc.el (mpc--proc-connect): use file-name-absolute-p
Date: Mon, 07 Sep 2015 21:16:16 -0400 [thread overview]
Message-ID: <jwvh9n5btmw.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <1441668682-21988-3-git-send-email-mvoteiza@udel.edu> (Mark Oteiza's message of "Mon, 7 Sep 2015 19:31:22 -0400")
> - (when (string-prefix-p "/" host) ;FIXME: Use file-name-absolute-p?
> + (when (file-name-absolute-p host)
> + ;; Expand file name because `file-name-absolute-p'
> + ;; considers paths beginning with "~" as absolute
> + (setq host (expand-file-name host))
So do you think using file-name-absolute-p is better?
I left it as a FIXME, because I simply didn't know the answer.
If you set $MPD_HOST to "~/.mpdsocket" do other MPD clients handle
it correctly?
What about under w32?
Stefan
next prev parent reply other threads:[~2015-09-08 1:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-07 23:31 [PATCH 1/3] lisp/mpc.el (mpc-file-local-copy): check more config locations Mark Oteiza
2015-09-07 23:31 ` [PATCH 2/3] lisp/mpc.el (mpc-file-local-copy): check for absolute path Mark Oteiza
2015-09-07 23:31 ` [PATCH 3/3] lisp/mpc.el (mpc--proc-connect): use file-name-absolute-p Mark Oteiza
2015-09-08 1:16 ` Stefan Monnier [this message]
2015-09-08 1:57 ` Mark Oteiza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvh9n5btmw.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=mvoteiza@udel.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).