From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Permission requested to merge branch comment-cache into master. Date: Sun, 13 Mar 2016 13:22:52 -0400 Message-ID: References: <20160312002837.GJ2888@acm.fritz.box> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1457889797 11237 80.91.229.3 (13 Mar 2016 17:23:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 13 Mar 2016 17:23:17 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 13 18:23:09 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1af9jQ-0007x8-F8 for ged-emacs-devel@m.gmane.org; Sun, 13 Mar 2016 18:23:08 +0100 Original-Received: from localhost ([::1]:36916 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1af9jP-0003KV-Lw for ged-emacs-devel@m.gmane.org; Sun, 13 Mar 2016 13:23:07 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38143) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1af9jK-0003Gj-4h for emacs-devel@gnu.org; Sun, 13 Mar 2016 13:23:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1af9jG-0005Db-V6 for emacs-devel@gnu.org; Sun, 13 Mar 2016 13:23:02 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:34356) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1af9jG-0005DU-ON for emacs-devel@gnu.org; Sun, 13 Mar 2016 13:22:58 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1af9jF-0007s3-K5 for emacs-devel@gnu.org; Sun, 13 Mar 2016 18:22:57 +0100 Original-Received: from 75-119-255-146.dsl.teksavvy.com ([75.119.255.146]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 13 Mar 2016 18:22:57 +0100 Original-Received: from monnier by 75-119-255-146.dsl.teksavvy.com with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 13 Mar 2016 18:22:57 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 21 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 75-119-255-146.dsl.teksavvy.com User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) Cancel-Lock: sha1:WBG0eLJgaW4wpA1pGaj+DRP9c3w= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:201613 Archived-At: > An alternative approach using the syntax-ppss cache has been discussed > and tried. It's a much smaller patch and no bug has been demonstrated with it (other than artificial examples where it's not even unambiguous what would be the right answer, because it's far from clear how we'd ever get into such a situation). In any case, I'm opposed to the way this is implemented, so if my voice has any value, I want to record my strong opposition to it. In case you don't want to dig into the whole thread, the core reason why I'm opposed to it is because it introduces a parallel cache to the one used in syntax-ppss, and I think we should only have a single cache for that. So if his patch is extended to completely replace syntax-ppss, my objection would be addressed. Stefan