unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Subject: Re: Permission requested to merge branch comment-cache into master.
Date: Sun, 13 Mar 2016 13:22:52 -0400	[thread overview]
Message-ID: <jwvh9gacn2w.fsf-monnier+gmane.emacs.devel@gnu.org> (raw)
In-Reply-To: 20160312002837.GJ2888@acm.fritz.box

> An alternative approach using the syntax-ppss cache has been discussed
> and tried.

It's a much smaller patch and no bug has been demonstrated with it
(other than artificial examples where it's not even unambiguous what
would be the right answer, because it's far from clear how we'd ever
get into such a situation).

In any case, I'm opposed to the way this is implemented, so if my voice has
any value, I want to record my strong opposition to it.

In case you don't want to dig into the whole thread, the core reason why
I'm opposed to it is because it introduces a parallel cache to the one
used in syntax-ppss, and I think we should only have a single cache
for that.

So if his patch is extended to completely replace syntax-ppss, my
objection would be addressed.


        Stefan




      parent reply	other threads:[~2016-03-13 17:22 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-12  0:28 Permission requested to merge branch comment-cache into master Alan Mackenzie
2016-03-12  7:32 ` Eli Zaretskii
2016-03-12 10:08   ` Alan Mackenzie
2016-03-12 11:14     ` Eli Zaretskii
2016-03-12 11:50       ` Alan Mackenzie
2016-03-12 12:31         ` Eli Zaretskii
2016-03-12 13:11           ` Alan Mackenzie
2016-03-12 21:38           ` John Wiegley
2016-03-12 23:17             ` Alan Mackenzie
2016-03-13  0:02               ` John Wiegley
2016-03-13 15:20                 ` Alan Mackenzie
2016-03-13 16:04                   ` Clément Pit--Claudel
2016-03-13 16:12                     ` Dmitry Gutov
2016-03-13 19:12                     ` Alan Mackenzie
2016-03-13 22:27                       ` Stefan Monnier
2016-03-13 22:52                         ` Alan Mackenzie
2016-03-13 23:38                           ` Clément Pit--Claudel
2016-03-14  0:20                           ` Stefan Monnier
2016-03-14  6:32                           ` Andreas Röhler
2016-03-14 11:27                             ` Alan Mackenzie
2016-03-13 17:07                   ` John Wiegley
2016-03-13 19:04                     ` Alan Mackenzie
2016-03-14  0:25                   ` Dmitry Gutov
2016-03-14  1:11                   ` Stefan Monnier
2016-03-14 13:28                     ` Alan Mackenzie
2016-03-14 15:58                       ` Stefan Monnier
2016-03-13 18:03               ` Eli Zaretskii
2016-03-12 13:23 ` Dmitry Gutov
2016-03-12 14:06   ` Alan Mackenzie
2016-03-12 21:39   ` John Wiegley
2016-03-13 17:22 ` Stefan Monnier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvh9gacn2w.fsf-monnier+gmane.emacs.devel@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).