* Re: [Emacs-diffs] master 43cc5d8: Make `q' etc work in image mode again
[not found] ` <E1auKvo-0007KF-7J@vcs.savannah.gnu.org>
@ 2016-04-24 14:59 ` Stefan Monnier
2016-04-24 15:11 ` Lars Magne Ingebrigtsen
0 siblings, 1 reply; 5+ messages in thread
From: Stefan Monnier @ 2016-04-24 14:59 UTC (permalink / raw)
To: emacs-devel; +Cc: Lars Magne Ingebrigtsen
> - (let ((map (make-sparse-keymap)))
> + (let ((map (copy-keymap image-map)))
> (set-keymap-parent map special-mode-map)
> - (set-keymap-parent map image-map)
We should avoid using copy-keymap. If you want multiple-inheritance, we
have it now: use make-composed-keymap.
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Emacs-diffs] master 43cc5d8: Make `q' etc work in image mode again
2016-04-24 14:59 ` [Emacs-diffs] master 43cc5d8: Make `q' etc work in image mode again Stefan Monnier
@ 2016-04-24 15:11 ` Lars Magne Ingebrigtsen
2016-04-24 15:17 ` Lars Magne Ingebrigtsen
0 siblings, 1 reply; 5+ messages in thread
From: Lars Magne Ingebrigtsen @ 2016-04-24 15:11 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> We should avoid using copy-keymap. If you want multiple-inheritance, we
> have it now: use make-composed-keymap.
Ah, great.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Emacs-diffs] master 43cc5d8: Make `q' etc work in image mode again
2016-04-24 15:11 ` Lars Magne Ingebrigtsen
@ 2016-04-24 15:17 ` Lars Magne Ingebrigtsen
2016-04-24 15:22 ` Lars Magne Ingebrigtsen
0 siblings, 1 reply; 5+ messages in thread
From: Lars Magne Ingebrigtsen @ 2016-04-24 15:17 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>
>> We should avoid using copy-keymap. If you want multiple-inheritance, we
>> have it now: use make-composed-keymap.
>
> Ah, great.
Uhm... something weird happened. Now all the image mode commands are
bound in the image-map keymap?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Emacs-diffs] master 43cc5d8: Make `q' etc work in image mode again
2016-04-24 15:17 ` Lars Magne Ingebrigtsen
@ 2016-04-24 15:22 ` Lars Magne Ingebrigtsen
2016-04-24 19:45 ` Stefan Monnier
0 siblings, 1 reply; 5+ messages in thread
From: Lars Magne Ingebrigtsen @ 2016-04-24 15:22 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
> Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
>
>> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>>
>>> We should avoid using copy-keymap. If you want multiple-inheritance, we
>>> have it now: use make-composed-keymap.
>>
>> Ah, great.
>
> Uhm... something weird happened. Now all the image mode commands are
> bound in the image-map keymap?
Ah, that's not how you're suppose to call that function, because if you
modify the map afterwards, they ... happen in the first of the composed
maps? Kinda confusing.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Emacs-diffs] master 43cc5d8: Make `q' etc work in image mode again
2016-04-24 15:22 ` Lars Magne Ingebrigtsen
@ 2016-04-24 19:45 ` Stefan Monnier
0 siblings, 0 replies; 5+ messages in thread
From: Stefan Monnier @ 2016-04-24 19:45 UTC (permalink / raw)
To: Lars Magne Ingebrigtsen; +Cc: emacs-devel
> Ah, that's not how you're suppose to call that function, because if you
> modify the map afterwards, they ... happen in the first of the composed
> maps? Kinda confusing.
Yes, it's a quirk that's hard to avoid because key lookup can return such
a composed keymap, and define-key uses that same key lookup after which
it needs to find the actual submap to modify.
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-04-24 19:45 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20160424142240.28121.22307@vcs.savannah.gnu.org>
[not found] ` <E1auKvo-0007KF-7J@vcs.savannah.gnu.org>
2016-04-24 14:59 ` [Emacs-diffs] master 43cc5d8: Make `q' etc work in image mode again Stefan Monnier
2016-04-24 15:11 ` Lars Magne Ingebrigtsen
2016-04-24 15:17 ` Lars Magne Ingebrigtsen
2016-04-24 15:22 ` Lars Magne Ingebrigtsen
2016-04-24 19:45 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).