unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Cc: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [Emacs-diffs] emacs-25 f785ff4: Clarify documentation of before/after-change-functions
Date: Tue, 09 Aug 2016 13:59:25 -0400	[thread overview]
Message-ID: <jwvh9atn7uk.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <20160809165416.A7F9A220165@vcs.savannah.gnu.org> (Eli Zaretskii's message of "Tue,  9 Aug 2016 16:54:16 +0000 (UTC)")

> -This variable holds a list of functions to call before any buffer
> -modification.  Each function gets two arguments, the beginning and end
> +This variable holds a list of functions to call before most buffer
> +modifications.  Each function gets two arguments, the beginning and end

This looks wrong.  It should be called before *every* modification.
syntax-ppss relies on this property, for example.
And I can't think of any reason why we couldn't preserve that property.

In which case is it not run?


        Stefan



       reply	other threads:[~2016-08-09 17:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20160809165416.24861.65995@vcs.savannah.gnu.org>
     [not found] ` <20160809165416.A7F9A220165@vcs.savannah.gnu.org>
2016-08-09 17:59   ` Stefan Monnier [this message]
2016-08-09 18:18     ` [Emacs-diffs] emacs-25 f785ff4: Clarify documentation of before/after-change-functions Eli Zaretskii
2016-08-09 19:02       ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvh9atn7uk.fsf-monnier+emacsdiffs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).