From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-26 ee512e9: Ignore buffers whose name begins with a space in save-some-buffers Date: Tue, 19 Sep 2017 08:42:18 -0400 Message-ID: References: <20170918202953.21378.63492@vcs0.savannah.gnu.org> <20170918202955.5043420AC4@vcs0.savannah.gnu.org> <87ingfcrf6.fsf@ericabrahamsen.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1505826125 25276 195.159.176.226 (19 Sep 2017 13:02:05 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 19 Sep 2017 13:02:05 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Sep 19 15:01:48 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1duI9l-0005Xx-20 for ged-emacs-devel@m.gmane.org; Tue, 19 Sep 2017 15:01:41 +0200 Original-Received: from localhost ([::1]:42705 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1duI9s-0004U1-5x for ged-emacs-devel@m.gmane.org; Tue, 19 Sep 2017 09:01:48 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40378) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1duHrJ-0006BC-IG for emacs-devel@gnu.org; Tue, 19 Sep 2017 08:42:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1duHrG-0005iX-Dz for emacs-devel@gnu.org; Tue, 19 Sep 2017 08:42:37 -0400 Original-Received: from [195.159.176.226] (port=53136 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1duHrG-0005hY-7S for emacs-devel@gnu.org; Tue, 19 Sep 2017 08:42:34 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1duHr4-0005zR-6b for emacs-devel@gnu.org; Tue, 19 Sep 2017 14:42:22 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 25 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:VxTiSL5DaDDHsMVeyV7eVT8xqHg= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:218515 Archived-At: > This was fallout from 9b980e269, aka bug #28412, where now we prompt for > buffers that have functions in the `write-contents-functions' hook. Ah, I see I was looking at the wrong version of the code, sorry. So the question becomes: why does " *Code-Fontify*" have a non-nil write-contents-functions? Looking at ggtags.el, I also wonder why the buffer survives the call to ggtags-fontify-code. I would have expected ggtags-fontify-code to look more like: (cl-defun ggtags-fontify-code (code &optional (mode major-mode)) (cl-check-type mode function) (cl-typecase code ;; FIXME: Using `stringp` is more efficient. ((not string) code) (string (with-temp-buffer (insert code) ;; FIXME: `delay-mode-hooks' needs a comment (delay-mode-hooks (funcall mode)) (font-lock-ensure) (buffer-string))))) -- Stefan