* Re: master c7d2a0d: * lisp/emacs-lisp/benchmark.el (benchmark-run): Allow variable.
[not found] ` <20180327010741.DB51620512@vcs0.savannah.gnu.org>
@ 2018-03-27 1:26 ` Glenn Morris
2018-03-27 2:08 ` Stefan Monnier
0 siblings, 1 reply; 4+ messages in thread
From: Glenn Morris @ 2018-03-27 1:26 UTC (permalink / raw)
To: emacs-devel; +Cc: Stefan Monnier
Stefan Monnier wrote:
> branch: master
> commit c7d2a0dd76fbfaedb4caedac261bd0a8944281a8
This breaks
(benchmark-run nil (setq m (1+ 0)))
the very first test in benchmark-tests.el.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: master c7d2a0d: * lisp/emacs-lisp/benchmark.el (benchmark-run): Allow variable.
2018-03-27 1:26 ` master c7d2a0d: * lisp/emacs-lisp/benchmark.el (benchmark-run): Allow variable Glenn Morris
@ 2018-03-27 2:08 ` Stefan Monnier
2018-03-27 19:50 ` Glenn Morris
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2018-03-27 2:08 UTC (permalink / raw)
To: emacs-devel
> (benchmark-run nil (setq m (1+ 0)))
What's the intended meaning of this nil?
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: master c7d2a0d: * lisp/emacs-lisp/benchmark.el (benchmark-run): Allow variable.
2018-03-27 2:08 ` Stefan Monnier
@ 2018-03-27 19:50 ` Glenn Morris
2018-03-27 20:06 ` Stefan Monnier
0 siblings, 1 reply; 4+ messages in thread
From: Glenn Morris @ 2018-03-27 19:50 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
[Please reply-to-all on GNU lists.
If reading by gmane, you can still respond by mail.]
Stefan Monnier wrote:
>> (benchmark-run nil (setq m (1+ 0)))
>
> What's the intended meaning of this nil?
I assume nil means 1. Doesn't seem particularly sensible, but there you go.
Whatever happens, benchmark-run and benchmark-run-compiled should be
consistent.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: master c7d2a0d: * lisp/emacs-lisp/benchmark.el (benchmark-run): Allow variable.
2018-03-27 19:50 ` Glenn Morris
@ 2018-03-27 20:06 ` Stefan Monnier
0 siblings, 0 replies; 4+ messages in thread
From: Stefan Monnier @ 2018-03-27 20:06 UTC (permalink / raw)
To: emacs-devel
>> What's the intended meaning of this nil?
> I assume nil means 1. Doesn't seem particularly sensible, but there you go.
Until now it didn't: it was taken as an instruction to execute, i.e.
(benchmark-run nil (setq m (1+ 0)))
is treated as
(benchmark-run 1 (progn nil (setq m (1+ 0))))
rather than
(benchmark-run 1 (setq m (1+ 0)))
It just happens to do the same. The same holds for
(benchmark-run (+ 3 4) (setq m (1+ 0)))
which behaves like
(benchmark-run 1 (+ 3 4) (setq m (1+ 0)))
> Whatever happens, benchmark-run and benchmark-run-compiled should be
> consistent.
Oh, right, I did miss this one, thanks,
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-03-27 20:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20180327010741.32424.61536@vcs0.savannah.gnu.org>
[not found] ` <20180327010741.DB51620512@vcs0.savannah.gnu.org>
2018-03-27 1:26 ` master c7d2a0d: * lisp/emacs-lisp/benchmark.el (benchmark-run): Allow variable Glenn Morris
2018-03-27 2:08 ` Stefan Monnier
2018-03-27 19:50 ` Glenn Morris
2018-03-27 20:06 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).