From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Allow hiding stashes from vc-dir Date: Fri, 18 Oct 2019 09:22:22 -0400 Message-ID: References: <831rvegnub.fsf@gnu.org> <871rvex9ue.fsf@mail.linkov.net> <87eezdpjh4.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="17701"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Eli Zaretskii , emacs-devel@gnu.org, Juri Linkov To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 18 15:23:02 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iLSDd-0004S9-Ar for ged-emacs-devel@m.gmane.org; Fri, 18 Oct 2019 15:23:01 +0200 Original-Received: from localhost ([::1]:39968 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iLSDc-0007vo-2Y for ged-emacs-devel@m.gmane.org; Fri, 18 Oct 2019 09:23:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50427) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iLSD7-0007va-GF for emacs-devel@gnu.org; Fri, 18 Oct 2019 09:22:30 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iLSD6-0000Vz-10 for emacs-devel@gnu.org; Fri, 18 Oct 2019 09:22:29 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:14548) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iLSD4-0000VA-Ky; Fri, 18 Oct 2019 09:22:26 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 650C88122F; Fri, 18 Oct 2019 09:22:25 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 27D7E80C84; Fri, 18 Oct 2019 09:22:24 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1571404944; bh=3Dnv8vNyhS/T/iwRFQ5JBOdZOTkyDNidLmSDyQ5qPdk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=AnGLtwv7haihy7QriZRw9hZ9xI4n39tTnA+NaEo2XnZg/t5hipiWkQk78vyKwSiAW DLmpP6dsCrbOvQHc0eo2EuHM7HIgw3stOf9TeeNkqAPE8Aqi4bttJBr0r3LcYy7bm7 HVoFGQi1iazndZoiPVuzyylGp7hHq7hLjiiXb90F41BnKpLaoB6czfXpr1TnR6h0OV +dfHDU4bz+bDImZV1dfyQAEx5CidEdWxvvTpRtmDxPT+O9qMj8Q3WcRwrLSN8i3pqK 9ue1um9hPkgRzchtQFeVemgRc5DZO/P6fPGpIfhxp95yVOeP3Oh6q5zzwQWow73loF ohxF5T9tNAl1Q== Original-Received: from pastel (unknown [216.154.15.203]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id E1198120F87; Fri, 18 Oct 2019 09:22:23 -0400 (EDT) In-Reply-To: (Robert Pluim's message of "Thu, 17 Oct 2019 18:26:10 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:241204 Archived-At: > +(declare-function cl-subseq "cl-extra" (seq start &optional end)) Wrong fix: if you want to use cl-lib functions, then you need to (require 'cl-lib) outside of an eval-when-compile. IOW you need: diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el index 9715aea1fd..aa3b41454d 100644 --- a/lisp/vc/vc-git.el +++ b/lisp/vc/vc-git.el @@ -102,8 +102,8 @@ ;;; Code: +(require 'cl-lib) (eval-when-compile - (require 'cl-lib) (require 'subr-x) ; for string-trim-right (require 'vc) (require 'vc-dir)) -- Stefan