From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 9ade7ea: Fix Eldoc problem when loading on Emacs 26.3 Date: Fri, 10 Jul 2020 17:35:14 -0400 Message-ID: References: <20200710004934.18557.69586@vcs0.savannah.gnu.org> <20200710004936.2935520A27@vcs0.savannah.gnu.org> <0veepjz719.fsf@fencepost.gnu.org> <87lfjrdzna.fsf@gmail.com> <87h7ufdtyr.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36012"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Glenn Morris , Noam Postavsky , emacs-devel To: =?windows-1252?B?Sm/jbyBU4XZvcmE=?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jul 10 23:36:17 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ju0gp-0009ES-P9 for ged-emacs-devel@m.gmane-mx.org; Fri, 10 Jul 2020 23:36:15 +0200 Original-Received: from localhost ([::1]:41406 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ju0go-0003LS-QD for ged-emacs-devel@m.gmane-mx.org; Fri, 10 Jul 2020 17:36:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56394) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ju0g1-0002nI-Ad for emacs-devel@gnu.org; Fri, 10 Jul 2020 17:35:25 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:48426) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ju0fz-00044P-9y; Fri, 10 Jul 2020 17:35:24 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id DCC791012E2; Fri, 10 Jul 2020 17:35:21 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id F0823100ED1; Fri, 10 Jul 2020 17:35:15 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1594416915; bh=2a5043Otgb9LaUnDZmFsv/zsK45fHKoZ/aEc7h+PzNw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Rd4aEzFZ7eVjRf+CtX916JlP3RMQimjSOaGtnEis6T09CYSJyKhvln0cZ2RD+uvkf P9CHn/ttmDbG+9OLVxhybNPqp83a7addNi5BX1+TBVKwcLM8ufaHRj4Spmctz2XnuD 67E2rIWHOUDgaGetDGafelkcUVxz5lD08umRTzXMfRCj2rdSkQ0jJeGUSykQTkd90U iNHvmBZj0xCYsIRo/VVfugyjFghKgyh633NMhNrUFKeRumvDaN5w/FGm9xUvnf5cmI Z6oxBhEXxMod2N3MTmzrLJk5pZtFKdny/hWa+QY0Z55FSJ/n2ZhXv7JVaePrBIy8TI nJodhu9QfxcJQ== Original-Received: from alfajor (unknown [157.52.23.7]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id A96B61201E7; Fri, 10 Jul 2020 17:35:15 -0400 (EDT) In-Reply-To: <87h7ufdtyr.fsf@gmail.com> (=?windows-1252?Q?=22Jo=E3o_T=E1vo?= =?windows-1252?Q?ra=22's?= message of "Fri, 10 Jul 2020 20:57:00 +0100") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/10 17:29:13 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:252842 Archived-At: >> Maybe come up with a better idea, or maybe, like Stefan suggests, don't >> make it an alias at all, just deprecate it and keep using it instead of >> eldoc-documentation-strategy when we find it to be bound. > > That sort of works, but it forces extensions that do want to > "Package-Require" eldoc to remember to unbind > eldoc-documentation-function if they are loaded on older Emacs versions, > which is undesirable. Maybe use a rule like: (if (and (buffer-local-p 'eldoc-documentation-function) (not (buffer-local-p 'eldoc-documentation-functions))) -- Stefan