From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master f450798: Don't move point in vc-dir on vc-register/vc-checkin (bug#43188) Date: Tue, 15 Sep 2020 16:32:39 -0400 Message-ID: References: <20200904211737.15548.63989@vcs0.savannah.gnu.org> <20200904211738.DA94720667@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34951"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Andrii Kolomoiets Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 15 22:33:24 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kIHdj-0008z1-3Y for ged-emacs-devel@m.gmane-mx.org; Tue, 15 Sep 2020 22:33:23 +0200 Original-Received: from localhost ([::1]:37154 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kIHdi-0000l6-3o for ged-emacs-devel@m.gmane-mx.org; Tue, 15 Sep 2020 16:33:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34510) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIHdE-0000JU-9B for emacs-devel@gnu.org; Tue, 15 Sep 2020 16:32:52 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:20710) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIHdB-0003vi-U0 for emacs-devel@gnu.org; Tue, 15 Sep 2020 16:32:51 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 53DF5441131; Tue, 15 Sep 2020 16:32:48 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id DCAE7440083; Tue, 15 Sep 2020 16:32:39 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1600201959; bh=xt+xhO5ev4wIVJmX6ha3AK3aN1jX4zgtD44RS5bfoww=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=figv6KBvRFYI6nXUnnnC++t+Ezmt8FbPeCsSW12OR/9E5x4/crvajGL311U+V6yU+ s9eQXkIQ6tpt6oRKW8AFKFyTPsAqhQQpzfSY0HNvctNuGbpryldWT6VPhLXU2ULaZj AxIQYuR3da/tVT+1ntmB0myyhasTJBokfiGSDOPAsjC+hMLaUO+wEXboLqi52yiEUd ptaPChCbZkUVhL2dNvel+C27h/qzb2MiO0VK59wHowceZfw7sVGPGk42Ltpmkjn6TV M/I0MFQeIqVmEggWMSDWESWKA4Db0XeT/SS2nNgc1f4bZbGhQsvzhhZ9gtUGYsfSjK fiC9FY9DCMuNQ== Original-Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 9944712028A; Tue, 15 Sep 2020 16:32:39 -0400 (EDT) In-Reply-To: (Andrii Kolomoiets's message of "Tue, 15 Sep 2020 22:14:12 +0300") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/15 16:05:56 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:255790 Archived-At: > Your code works great except: > >> + (goto-char (+ m (* percent (- end m))))))) > ^ this must be wrapped with (round) > > Also I would move point by offset rather than percent to save exactly > the same position. Feel free to do that, yes (of course taking care of the case where the new text is shorter than the original position). I only used `percent` as an example. Stefan