From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: resize_mini_window question Date: Fri, 18 Sep 2020 11:30:58 -0400 Message-ID: References: <20200918150113.4vz5vq3krfslrwdz.ref@Ergus> <20200918150113.4vz5vq3krfslrwdz@Ergus> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37491"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Ergus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Sep 18 17:43:19 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kJIXe-0009dg-MN for ged-emacs-devel@m.gmane-mx.org; Fri, 18 Sep 2020 17:43:18 +0200 Original-Received: from localhost ([::1]:39192 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJIXd-0005QV-Nq for ged-emacs-devel@m.gmane-mx.org; Fri, 18 Sep 2020 11:43:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54084) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJILp-0000uF-UZ for emacs-devel@gnu.org; Fri, 18 Sep 2020 11:31:06 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:55906) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJILn-0004rn-HI; Fri, 18 Sep 2020 11:31:04 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id CB95A100234; Fri, 18 Sep 2020 11:31:01 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 0F92A10001F; Fri, 18 Sep 2020 11:31:00 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1600443060; bh=Sh6vMqFcWp9MM3Y5lsQ8J4Aqf/FUtMBRAtu5HEGgubk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=T/MuS8oHPRhz2oEDtgG+8YUeyu5UXSmo+QiOm/elb4ZXYicsdsstkgw6jSmW/clrN OIDA5zZVzjOCiawWrxppfxdBMGTbu4/BoNYvdOU75kpodtUOwcXTuvR6RiWGo6XJQt HEb4wAlDGGUFB6KbcaLnrxwvTMwvQ+QXJZbngkxdWh1cD8nMq6Vji4wqRyQE882hJ7 gBzLAWK98YPMRulFT+KVLXmjLVUnV5CJpyx4KStjPmiYRpQpc8y7vpWen5zpLwUGRW /3DeaE1YyfigXL3FqTTMF/yaZXI3FRKZ7ZrqzLzb4uRyezn8vjIDYFzgnIKs3YwRpR M17Kwh5fBBZcg== Original-Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id AE054120778; Fri, 18 Sep 2020 11:30:59 -0400 (EDT) In-Reply-To: <20200918150113.4vz5vq3krfslrwdz@Ergus> (Ergus's message of "Fri, 18 Sep 2020 17:01:13 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/18 11:15:06 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:256101 Archived-At: > I see 3 possible clean solutions: > > 1) Modify resize_mini_window to use the minibuffer's font size to > calculate the height when Vmax_mini_window_height is an int. (don't know > if it is possible to access the minibuffer font size from there or if > this could produce some undesired side effect) I don't think this will work reliably, e.g. even if your minibuffer only has N lines of text, line wrapping different fonts used for different scripts, plus overlays and text-properties applied to specific parts of the minibuffer's content will make that computation fail to give the desired result. > 3) Just force the text to fit ignoring that the number of real visible > lines will be different than max-mini-window-height. It might not even be possible anyway if the minibuffer's content uses up more space than available in the frame. > (This will be seen as ignoring the max-mini-window-height) Indeed, which is another problem with this option. > 2) Modify the documentation of max-mini-window-height to specify that if > an integer, it specifies a number of lines respecting to the frame's > default font, not the minibuffer's visible lines. That sounds good. It's not sufficient to fix the problem in `icomplete-vertical` obviously, so `icomplete-vertical` would need to be changed. Maybe it could check the `window-end` to detect when the minibuffer's content is larger than what fits and shorten it accordingly? Stefan