From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Juri Linkov <juri@linkov.net>
Cc: spacibba@aol.com, Jean Louis <bugs@gnu.support>,
andreyk.mad@gmail.com, emacs-devel@gnu.org, rudalics@gmx.at,
Gregory Heytings <ghe@sdf.org>, Eli Zaretskii <eliz@gnu.org>,
Drew Adams <drew.adams@oracle.com>
Subject: Re: select yank via completion
Date: Fri, 20 Nov 2020 09:23:31 -0500 [thread overview]
Message-ID: <jwvh7pk3yjm.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87o8jsiems.fsf@mail.linkov.net> (Juri Linkov's message of "Fri, 20 Nov 2020 10:53:39 +0200")
> So now a new patch let-binds (minibuffer-completing-file-name t)
> around completing-read to allow inserting SPC, problem solved:
Please don't, since we're not actually completing file names.
I agree with Drew that we should probably just get rid of the SPC
binding in minibuffer completions, but until we do that you'll need
(minibuffer-with-setup-hook
(lambda ()
(use-local-map
(let ((map (make-sparse-keymap)))
(set-keymap-parent map (current-local-map))
(define-key map " " nil)
map)))
...)
or something similar. We could/should arguably introduce some easier
way to do that. Maybe something like the patch below so you can just do
(minibuffer-with-setup-hook
(lambda () (setq-local minibuffer-SPC-completes nil))
...)
??
Stefan
diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el
index 9d57a817b2..20df9665a2 100644
--- a/lisp/minibuffer.el
+++ b/lisp/minibuffer.el
@@ -2342,6 +2342,8 @@ completion-help-at-point
(define-key map "\r" 'exit-minibuffer)
(define-key map "\n" 'exit-minibuffer))
+(defvar minibuffer-SPC-completes t)
+
(defvar minibuffer-local-completion-map
(let ((map (make-sparse-keymap)))
(set-keymap-parent map minibuffer-local-map)
@@ -2349,7 +2351,9 @@ minibuffer-local-completion-map
;; M-TAB is already abused for many other purposes, so we should find
;; another binding for it.
;; (define-key map "\e\t" 'minibuffer-force-complete)
- (define-key map " " 'minibuffer-complete-word)
+ (define-key map " "
+ `(menu-item "" minibuffer-complete-word
+ :filter ,(lambda (cmd) (if minibuffer-SPC-completes cmd))))
(define-key map "?" 'minibuffer-completion-help)
(define-key map [prior] 'switch-to-completions)
(define-key map "\M-v" 'switch-to-completions)
next prev parent reply other threads:[~2020-11-20 14:23 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 17:42 on helm substantial differences Drew Adams
2020-11-13 21:16 ` Jean Louis
2020-11-15 11:49 ` Jean Louis
2020-11-15 20:07 ` Juri Linkov
2020-11-15 22:01 ` Stefan Monnier
2020-11-15 22:41 ` Drew Adams
2020-11-16 8:58 ` Juri Linkov
2020-11-16 16:03 ` Drew Adams
2020-11-16 17:36 ` Stefan Monnier
2020-11-16 20:38 ` Juri Linkov
2020-11-16 21:54 ` Stefan Monnier
2020-11-17 19:18 ` Juri Linkov
2020-11-17 20:32 ` Juri Linkov
2020-11-18 9:10 ` Juri Linkov
2020-11-18 11:38 ` Basil L. Contovounesios
2020-11-18 19:13 ` Juri Linkov
2020-11-18 20:33 ` Juri Linkov
2020-11-20 9:24 ` Juri Linkov
2020-11-20 11:57 ` Eli Zaretskii
2020-11-20 12:15 ` Eli Zaretskii
2020-11-20 14:39 ` Stefan Monnier
2020-11-21 20:18 ` Juri Linkov
2020-11-22 3:33 ` Eli Zaretskii
2020-11-22 8:36 ` Juri Linkov
2020-11-22 15:19 ` Eli Zaretskii
2020-11-22 20:11 ` Juri Linkov
2020-11-23 3:24 ` Eli Zaretskii
2020-11-25 9:10 ` Juri Linkov
2020-11-25 15:51 ` Eli Zaretskii
2020-11-25 19:16 ` Juri Linkov
2020-11-25 19:59 ` Eli Zaretskii
2020-11-25 20:35 ` Juri Linkov
2020-11-26 13:45 ` Eli Zaretskii
2020-11-27 8:45 ` Juri Linkov
2020-11-27 8:58 ` Eli Zaretskii
2020-11-27 9:17 ` Juri Linkov
2020-11-17 21:14 ` Jean Louis
2020-11-18 9:03 ` Juri Linkov
2020-11-18 19:21 ` Juri Linkov
2020-11-18 22:04 ` select yank via completion Stefan Monnier
2020-11-18 23:02 ` Drew Adams
2020-11-19 7:54 ` Juri Linkov
2020-11-19 17:00 ` Drew Adams
2020-11-20 8:53 ` Juri Linkov
2020-11-20 11:53 ` Eli Zaretskii
2020-11-21 19:38 ` Juri Linkov
2020-11-21 19:57 ` Eli Zaretskii
2020-11-21 20:43 ` Juri Linkov
2020-11-20 14:23 ` Stefan Monnier [this message]
2020-11-21 19:42 ` Juri Linkov
2020-11-21 21:08 ` Stefan Monnier
2020-11-21 22:21 ` Drew Adams
2020-11-21 22:48 ` Jean Louis
2020-11-21 23:00 ` Jean Louis
2020-11-25 19:25 ` Juri Linkov
2020-11-25 19:40 ` Drew Adams
2020-11-21 21:54 ` Drew Adams
2020-11-21 21:46 ` Drew Adams
2020-11-24 22:59 ` Basil L. Contovounesios
2020-11-25 7:36 ` Juri Linkov
2020-11-25 8:14 ` Andrii Kolomoiets
2020-11-25 20:24 ` Juri Linkov
2020-11-26 8:46 ` Basil L. Contovounesios
2020-11-26 9:26 ` Juri Linkov
2020-11-26 9:57 ` Eli Zaretskii
2020-11-26 21:17 ` Basil L. Contovounesios
2020-11-27 7:13 ` Eli Zaretskii
2020-11-27 9:01 ` Juri Linkov
2020-11-18 22:36 ` on helm substantial differences Drew Adams
2020-11-16 16:13 ` Eli Zaretskii
2020-11-16 20:41 ` Juri Linkov
2020-11-16 21:18 ` Drew Adams
2020-11-16 22:13 ` Juri Linkov
2020-11-17 0:04 ` Drew Adams
2020-11-17 8:38 ` Juri Linkov
2020-11-17 16:56 ` Drew Adams
2020-11-17 12:06 ` Protesilaos Stavrou
2020-11-17 17:29 ` Drew Adams
2020-11-17 19:23 ` Juri Linkov
2020-11-17 3:24 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvh7pk3yjm.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=andreyk.mad@gmail.com \
--cc=bugs@gnu.support \
--cc=drew.adams@oracle.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=ghe@sdf.org \
--cc=juri@linkov.net \
--cc=rudalics@gmx.at \
--cc=spacibba@aol.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).