From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] icomplete-vertical Date: Tue, 06 Apr 2021 10:11:45 -0400 Message-ID: References: <87h7kkwcy1.fsf@posteo.net> <83tuokb0uk.fsf@gnu.org> <87o8er3i8z.fsf@posteo.net> <87blar3glt.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25068"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Philip Kaludercic , Eli Zaretskii , emacs-devel@gnu.org To: Gregory Heytings Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 06 16:14:32 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lTmTP-0006Mr-Ne for ged-emacs-devel@m.gmane-mx.org; Tue, 06 Apr 2021 16:14:31 +0200 Original-Received: from localhost ([::1]:45646 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lTmTO-00023B-PQ for ged-emacs-devel@m.gmane-mx.org; Tue, 06 Apr 2021 10:14:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36776) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTmQu-0000b6-F9 for emacs-devel@gnu.org; Tue, 06 Apr 2021 10:11:56 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:34546) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTmQo-0001ZI-OE; Tue, 06 Apr 2021 10:11:55 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 83DB644077E; Tue, 6 Apr 2021 10:11:48 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 582A9440884; Tue, 6 Apr 2021 10:11:47 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1617718307; bh=qKnuqpiGdoPV3xidZkeOIIylRZp4libvgTZ/zn5jORE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=RipMOTGPZl9LD3rmLbd0kmXX6TbWmJ67DUF71p79dqI9X6aB+psaeOeIXfbOzndn+ wQq8dmnncCxmcvHrHkajItrV87Ed3rO1e4bcpQOvl5+MIpMVp/LGDS9Ofw4++axwfe 2OMsAtNv/vx4Er1ZRbN+8XSW0w3tb2SG30W9oS2VcXIxQrPXnJiHsfCmJNdFFe/NU7 03zfocbkjtVMY9E8DOeNFeRUNL3/8QXeUtcgrxEoB4J/2qxOHLrnjDi6/mfnUJzKr0 MCRCsAXCnddc/iGRWfGpqLA61aVngTEXzu6Fs4VbU6cokxCOUPlvJh0xfEPUN3PHBA AyKODoWqUcNRA== Original-Received: from alfajor (104-222-126-84.cpe.teksavvy.com [104.222.126.84]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 9AA1312040E; Tue, 6 Apr 2021 10:11:46 -0400 (EDT) In-Reply-To: (Gregory Heytings's message of "Tue, 06 Apr 2021 13:50:33 +0000") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267472 Archived-At: > Thanks a lot also for your other comments, which I included in the attached > revised patch. The only thing I wasn't sure is whether it was intentional > that you removed the :group 'icomplete from the minor mode tags, It was, since I presume this is placed inside the icomplete.el file where this arg is redundant. Stefan