From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 49e06183f5 1/3: Allow REQUIRE-MATCH to be a function Date: Sat, 11 Jun 2022 11:03:24 -0400 Message-ID: References: <165484935985.12525.14065631018362412932@vcs2.savannah.gnu.org> <20220610082240.A7222C01683@vcs2.savannah.gnu.org> <87pmjfsc1v.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39252"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org, Daniel Mendler To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jun 11 17:04:57 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o02fZ-0009zY-9I for ged-emacs-devel@m.gmane-mx.org; Sat, 11 Jun 2022 17:04:57 +0200 Original-Received: from localhost ([::1]:59510 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o02fY-0007Pb-5Q for ged-emacs-devel@m.gmane-mx.org; Sat, 11 Jun 2022 11:04:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55146) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o02eE-0006bR-Ur for emacs-devel@gnu.org; Sat, 11 Jun 2022 11:03:35 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:64722) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o02e9-000616-Qv for emacs-devel@gnu.org; Sat, 11 Jun 2022 11:03:32 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id E83448054F; Sat, 11 Jun 2022 11:03:26 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id A3484804BD; Sat, 11 Jun 2022 11:03:25 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1654959805; bh=k6EqXEuA/TAJ1NvOQftTsomLcqpQdH52cWlw1T2zS2o=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ew4CgjdcD/gjI60dzlWJ/5gmPQ34BHEGn4t/f/rXIxqIQG9QdV8mKyRuIGx7Temz4 u9jwFgSFUHE9REAdz39RByHmB20NwEmfWdnIlELuQGNbuNdpI+efrESkila+HmujnH WbcrA+XfE705GbtxtkORCthlr7Jve4EaIxfPLDPexn3JksOwjnooEdkPW05lxXcSwI mMUxik9gL4beJ+C1Axi6HU6o3k1q/Fbq9DWCEDgTXOw3eKXFkLCfb8oDNxzWdvBeGI szTJax7lgswDCXIJD2RkZSAu9ocY3PuUOB55v1GFA5aiAIFC2c6pi7893tRPmlZtnw 8jQAs6qDGdkHg== Original-Received: from pastel (unknown [45.72.221.51]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 646971202EE; Sat, 11 Jun 2022 11:03:25 -0400 (EDT) In-Reply-To: <87pmjfsc1v.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 11 Jun 2022 12:57:00 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:291034 Archived-At: >> I see that the `minibuffer-completion-confirm` function completely >> replaces the usual handling of require-match (i.e. the attempt to fix >> the case and the prompting for confirmation). > (You probably noticed it, but in case not -- I didn't change that code, > I just changed the indentation.) What I meant was that the branch you added to the `cond` overrides the rest of the `cond` (the part you reindented). >> Maybe this should be better documented, and also AFAICT currently >> a `minibuffer-completion-confirm` function cannot reliably reproduce this >> behavior by hand because it doesn't have access to `beg` and `end`. >> I think we should make this "default behavior" more easily accessible >> (e.g. put it into its own function and document it as something that can >> be called from `minibuffer-completion-confirm`?). > > I'm pretty sure I don't understand the subtleties here, but er sure? =F0= =9F=A7=90 Understanding the subtleties can be difficult, but a good general rule I try to follow in such cases is to provide a function that the new function-hook can use to get back the old behavior. IOW, arrange your code such that the user can provide a function `mimic-t` where the resulting behavior is identical to providing `t` (and same thing for the other supported values). AFAICT it's currently virtually impossible (at least not without inside knowledge of how the minibuffer.el code is written). Stefan