From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Splitting image-dired.el into smaller files Date: Sun, 21 Aug 2022 13:02:52 -0400 Message-ID: References: <83sflqcfhk.fsf@gnu.org> <83tu65br5f.fsf@gnu.org> <83r119bp35.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26463"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Stefan Kangas , emacs-devel@gnu.org, mathias.dahl@gmail.com To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Aug 21 19:04:15 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oPoMw-0006Xx-2j for ged-emacs-devel@m.gmane-mx.org; Sun, 21 Aug 2022 19:04:14 +0200 Original-Received: from localhost ([::1]:33286 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oPoMs-0002u2-A1 for ged-emacs-devel@m.gmane-mx.org; Sun, 21 Aug 2022 13:04:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37112) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oPoLk-0001cv-Ay for emacs-devel@gnu.org; Sun, 21 Aug 2022 13:03:00 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:35558) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oPoLh-0006uj-KB; Sun, 21 Aug 2022 13:02:59 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 94F1E80172; Sun, 21 Aug 2022 13:02:55 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 403CD8045E; Sun, 21 Aug 2022 13:02:54 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1661101374; bh=lmRK8xOmGAXnRS0klSwT6AdyYbK6hTyBzCSFMEI3Ros=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=NSUe4i8pK+B/UccBGhSCefS85bDwHT8pnFJIJ1UXGC1SiNbJdaE+/bopna7CEOLBc lCGS88gWX2bQ47nfQ0io/mP2njKFR4AKmyNuaqg/mEHFnKP42h95bk1IXxjF6HEuR0 +a0AFoFnZf+KxBMN9fn+68Rn3BtIA2sD4xtHsX4DKpsch91PD1DZTl5T+9lyP+HDOx O51Ngcmdw33UFYZOuPvK1TKkjNY00grb65zH8NO7d+Nrbntku75WB98LCaZZZF94he uk+miSclnxyJyiXmQPqD7WdcHaqLA/tZOdppUM1Z/ll+21v2XlCzYKLNUYwidc9flV H2g+j5MdGwWPw== Original-Received: from pastel (unknown [45.72.195.111]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 15AD9120295; Sun, 21 Aug 2022 13:02:54 -0400 (EDT) In-Reply-To: <83r119bp35.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 21 Aug 2022 18:20:30 +0300") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:293753 Archived-At: >> Do you mean naming the files like this? >> >> image-dired/compat.el >> image-dired/dired.el >> image-dired/external.el >> image-dired/gallery.el >> image-dired/tags.el >> image-dired/util.el >> image-dired/image-dired.el > > Yes. image-dired.el is not terribly large, so maybe keeping it as a single file is not a bad option either. I think the main goal in splitting files is when that lets us load only some of them in common use cases. >> How would I then require them, is it like this? >> >> (require 'image-dired/compat) >> >> If that works, it does sound a bit neater. > > It does work: we use it in cedet/ subdirectories. Indeed. It does suffer from various issues, tho (e.g. `load-history` doesn't remember that we used `image-dired/tags` to load the file so (eval-after-load "tags" ...) may run unexpectedly). It might be good to use it more widely to force us to face the problems and fix them, of course. >> > And maybe leave the -util.el part inside the main file? >> That's not very easy to do without introducing circular dependencies, >> unfortunately. I think most multi-file projects ends up using either ugly/broken hacks (e.g. ediff and viper), or a package-specific autoloads file for that (e.g. `mh-autoloads`, `cl-autoloads`, `tramp-autoloads`, ...). Lars's new autoloads code supports those autoloads file much better than the old one. Stefan