From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: Alan Mackenzie <acm@muc.de>, Eli Zaretskii <eliz@gnu.org>,
emacs-devel@gnu.org
Subject: Re: Excessive use of `eassert`
Date: Mon, 22 Jan 2024 08:20:13 -0500 [thread overview]
Message-ID: <jwvh6j5347s.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <1bcc2fc4-da9f-488e-b416-ef4443a3da65@cs.ucla.edu> (Paul Eggert's message of "Sun, 21 Jan 2024 20:12:09 -0800")
> Thanks, I reproduced that on Ubuntu 23.10 on x86-64 by configuring
> with --enable-checking and compiling with gcc -O0.
FWIW, I never compile with `-O0`, it's usually`-Og`.
And on i386 I saw it with `-O2` as well :-(
> +/* Equivalent to "make_lisp_symbol (&lispsym[INDEX])",
> + and typically faster when compiling without optimization. */
> +#define lisp_h_builtin_lisp_symbol(index) \
> + TAG_PTR (Lisp_Symbol, (index) * sizeof *lispsym)
[...]
> +(builtin_lisp_symbol) (int index)
> {
> - return make_lisp_symbol (&lispsym[index]);
> + return lisp_h_builtin_lisp_symbol (index);
> }
Hmm... Compared to the patch I proposed this has the downside that it
duplicates the logic between `lisp_h_builtin_lisp_symbol` and
`make_lisp_symbol` (worse: the logic is actually not the same, so it's
not obvious that it ends up returning the same thing).
Stefan
next prev parent reply other threads:[~2024-01-22 13:20 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 22:35 Excessive use of `eassert` Stefan Monnier
2024-01-19 7:04 ` Eli Zaretskii
2024-01-19 13:01 ` Stefan Monnier
2024-01-19 15:02 ` Eli Zaretskii
2024-01-19 15:50 ` Stefan Monnier
2024-01-19 16:23 ` Eli Zaretskii
2024-01-19 17:44 ` Stefan Monnier
2024-01-19 19:42 ` Alan Mackenzie
2024-01-19 19:56 ` Eli Zaretskii
2024-01-21 1:41 ` Paul Eggert
2024-01-21 9:57 ` Eli Zaretskii
2024-01-21 20:35 ` Paul Eggert
2024-01-21 10:59 ` Alan Mackenzie
2024-01-22 5:19 ` Paul Eggert
2024-01-22 13:07 ` Stefan Monnier
2024-01-22 14:37 ` Alan Mackenzie
2024-01-23 7:51 ` Paul Eggert
2024-01-23 11:42 ` Alan Mackenzie
2024-01-24 1:04 ` Paul Eggert
2024-01-24 15:09 ` Alan Mackenzie
2024-01-26 8:06 ` Paul Eggert
2024-01-21 15:54 ` Stefan Monnier
2024-01-22 4:12 ` Paul Eggert
2024-01-22 13:20 ` Stefan Monnier [this message]
2024-01-23 8:15 ` Paul Eggert
2024-01-23 17:11 ` Stefan Monnier
2024-01-24 7:45 ` Paul Eggert
2024-01-23 18:16 ` Eli Zaretskii
2024-01-23 19:50 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvh6j5347s.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=acm@muc.de \
--cc=eggert@cs.ucla.edu \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).