From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [nongnu] elpa/scala-mode c2a4f58643 1/2: Revert "scala-mode-indent.el: remove unused arg from `goto-block-anchor`" Date: Mon, 30 Dec 2024 19:08:05 -0500 Message-ID: References: <173560347147.2633946.7946382225330277437@vcs3.savannah.gnu.org> <20241231000431.DB05AE2FE49@vcs3.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4149"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Konstantin Kharlamov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 31 01:08:44 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tSPoR-0000yT-Pl for ged-emacs-devel@m.gmane-mx.org; Tue, 31 Dec 2024 01:08:44 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tSPoE-0000a9-Gf; Mon, 30 Dec 2024 19:08:30 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tSPo7-0000WR-JC for emacs-devel@gnu.org; Mon, 30 Dec 2024 19:08:23 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tSPo0-0000J0-KL for emacs-devel@gnu.org; Mon, 30 Dec 2024 19:08:23 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id AE58B805E9; Mon, 30 Dec 2024 19:08:10 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1735603685; bh=+wHVUyBziWjVzKhtYFYvMxtP3FH9TfNqayP5bKmRYzU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=WzxVOw1bUvsLYGGXW8WxSz1w4MyptSdmURmzwjBftfRpgE6uMWMvk2eHEEgDibcfh wvy3RIuLFzhgXzWf0K0wNYaYoqcBETfJJr17Ia/rySvBqoSBeU/4FpoN7QrYuQHvyl FL5qLtSnY+fCfPFmq3IRGD1lMdeW0vHjxyfxVNbi79+MInFnlDgTFBw4U7wO9kkJ0D l4B3TYE+nocFP2iflUQmfhW5VFLKQrRPMt9Mln1r92yNnSVcGIOHJN0ii8O/rLFiWp MkftajiANIj7oPUd96R2fMTaFwCHlYDU4REEthhRoVR5mwLmpi+8ClJSNGU5z55Nxn gX997GTqhAmHw== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id ADEA78034A; Mon, 30 Dec 2024 19:08:05 -0500 (EST) Original-Received: from alfajor (modemcable005.21-80-70.mc.videotron.ca [70.80.21.5]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 8D8B6120243; Mon, 30 Dec 2024 19:08:05 -0500 (EST) In-Reply-To: <20241231000431.DB05AE2FE49@vcs3.savannah.gnu.org> (ELPA Syncer's message of "Mon, 30 Dec 2024 19:04:31 -0500 (EST)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:327469 Archived-At: > branch: elpa/scala-mode > commit c2a4f58643eb505f38c8e341a29400e79f47f442 > Author: Konstantin Kharlamov > Commit: Konstantin Kharlamov > > Revert "scala-mode-indent.el: remove unused arg from `goto-block-anchor`" [...] > @@ -583,7 +583,7 @@ keyword, or nil if not." > ;;; Block > ;;; > > -(defun scala-indent:goto-block-anchor () > +(defun scala-indent:goto-block-anchor (&optional point) > "Moves back to the point whose column will be used as the > anchor for calculating block indent for current point (or point > `point'). Returns point or (point-min) if not inside a block." If the argument is unused, then you should rename it to `_point` which (by convention) says explicitly that this arg is not used. Stefan